Skip to content

Switch to evergreen URL for wasm-feature-detect library #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dschuff merged 4 commits into from
Nov 3, 2023
Merged

Switch to evergreen URL for wasm-feature-detect library #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7e400f
Switch to evergreen URL for wasm-feature-detect library
tomayac Nov 2, 2023
0a904d0
Switch back to jsdelivr, but evergreen
tomayac Nov 2, 2023
f0eb015
Update roadmap.md
tomayac Nov 3, 2023
fa491f6
Update roadmap.js
tomayac Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions roadmap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
);
for (const { name: featName, description, url } of features) {
const detectResult = h('td', {
headers: [idMap['table-col']('Your browser'), idMap['table-row'](featName)].join(' ')
headers: [idMap['table-col']('Your browser'), idMap['table-row'](featName)].join(' ')
}, [buildCellInner('loading')]);

detectWasmFeature(featName).then(supported => {
Expand Down Expand Up @@ -384,8 +384,10 @@
}

function _loadFeatureDetectModule() {
// Be sure to change the preloads in markdown when updating url.
const module = import('https://cdn.jsdelivr.net/npm/wasm-feature-detect@1.5/dist/esm/index.js');
// Please cache bust by bumping the `v` parameter whenever `feature.json` is
// updated to depend on a new version of the library. See #353 for discussion.
// Make sure to also match the preload link in `roadmap.md`.
const module = import('https://unpkg.com/wasm-feature-detect@1/dist/esm/index.js?v=1');
return (featureName) => module
.then(wasmFeatureDetect => wasmFeatureDetect[featureName]());
}
Expand Down
2 changes: 1 addition & 1 deletion roadmap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ The table below aims to track implemented features in popular engines:
</div>
<link rel="preload" href="/features.json" as="fetch">
<script src="/roadmap.js"></script>
<link rel="modulepreload" href="https://cdn.jsdelivr.net/npm/wasm-feature-detect@1/dist/esm/index.js">
<link rel="modulepreload" href="https://unpkg.com/wasm-feature-detect@1/dist/esm/index.js?v=1">
<link rel="modulepreload" href="https://cdn.jsdelivr.net/npm/@floating-ui/dom@1/+esm">

To detect supported features at runtime from JavaScript, check out the [`wasm-feature-detect` library](https://github.com/GoogleChromeLabs/wasm-feature-detect), which powers the "Your browser" column above.