Wpe 2.38 quirks by philn · Pull Request #1297 · WebPlatformForEmbedded/WPEWebKit

philn · 2024-03-11T14:28:04Z

No description provided.

philn · 2024-03-13T12:40:01Z

Hold on, I forgot to remove one ifdef...

philn · 2024-03-13T15:49:32Z

Hold on, I forgot to remove one ifdef...

This fixed, the PR is ready for testing/review!

emutavchi

Quirks should also allow changing playbin flags in MediaPlayerPrivateGStreamer::setPlaybackFlags . For example native-audio is Broadcom quirk.

philn · 2024-03-20T09:29:17Z

Quirks should also allow changing playbin flags in MediaPlayerPrivateGStreamer::setPlaybackFlags . For example native-audio is Broadcom quirk.

I wasn't aware of that. Yeah definitely, @calvaris already suggested removing those native-video/etc ifdefs. I can take a look.

https://bugs.webkit.org/show_bug.cgi?id=271308 Reviewed by Xabier Rodriguez-Calvar. The USE_GSTREAMER_TEXT_SINK and USE_GSTREAMER_NATIVE_{AUDIO,VIDEO} ifdefs were replaced with runtime quirks. This patch also includes changes requested in WebPlatformForEmbedded/WPEWebKit#1297. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::setPlaybackFlags): (WebCore::MediaPlayerPrivateGStreamer::createVideoSink): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: (WebCore::MediaPlayerPrivateGStreamer::pipeline const): * Source/WebCore/platform/gstreamer/GStreamerHolePunchQuirkWesteros.cpp: (WebCore::GStreamerHolePunchQuirkWesteros::createHolePunchVideoSink): * Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp: (WebCore::GStreamerQuirkAmLogic::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h: * Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp: (WebCore::GStreamerQuirksManager::getAdditionalPlaybinFlags const): * Source/WebCore/platform/gstreamer/GStreamerQuirks.h: (WebCore::GStreamerQuirk::getAdditionalPlaybinFlags const): * Source/cmake/GStreamerDefinitions.cmake: Canonical link: https://commits.webkit.org/276450@main

philn · 2024-03-21T10:10:45Z

I've rebased the branch and backported the changes requested by @emutavchi (see most recent commit).

calvaris

LGTM. What I don't know is if we should wait until we have a confirmation from @emutavchi .

emutavchi

Few more changes required, that were overlooked last time.

https://bugs.webkit.org/show_bug.cgi?id=269287 Reviewed by NOBODY (OOPS!). Compile-time quirks prevent re-usability of the same binaries across different platforms (using containers). The proposed solution is to always compile those, they don't depend on any specific APIs so that shouldn't be an issue. Then at runtime quirks can be tweaked using the WEBKIT_GST_QUIRKS and WEBKIT_GST_HOLE_PUNCH environment variables. * Source/WebCore/platform/SourcesGStreamer.txt: * Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp: (WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer): * Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp: (WebCore::decodebinAutoplugSelectCallback): (WebCore::AudioFileReader::~AudioFileReader): (WebCore::AudioFileReader::decodeAudioForBusCreation): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::ensureGStreamerInitialized): (WebCore::registerWebKitGStreamerElements): * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::ElementFactories::ElementFactories): (WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForCaps const): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::setSyncOnClock): (WebCore::MediaPlayerPrivateGStreamer::createAudioSink): (WebCore::MediaPlayerPrivateGStreamer::gstreamerPositionFromSinks const): (WebCore::MediaPlayerPrivateGStreamer::naturalSize const): (WebCore::MediaPlayerPrivateGStreamer::handleMessage): (WebCore::MediaPlayerPrivateGStreamer::configureElement): (WebCore::MediaPlayerPrivateGStreamer::configureElementPlatformQuirks): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): (WebCore::MediaPlayerPrivateGStreamer::swapBuffersIfNeeded): (WebCore::setRectangleToVideoSink): (WebCore::MediaPlayerPrivateGStreamer::isHolePunchRenderingEnabled const): (WebCore::MediaPlayerPrivateGStreamer::createHolePunchVideoSink): (WebCore::MediaPlayerPrivateGStreamer::shouldIgnoreIntrinsicSize): (WebCore::MediaPlayerPrivateGStreamer::createVideoSink): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * Source/WebCore/platform/gstreamer/GStreamerHolePunchQuirkBcmNexus.cpp: Added. (WebCore::GStreamerHolePunchQuirkBcmNexus::setHolePunchVideoRectangle): * Source/WebCore/platform/gstreamer/GStreamerHolePunchQuirkBcmNexus.h: Added. * Source/WebCore/platform/gstreamer/GStreamerHolePunchQuirkWesteros.cpp: Added. (WebCore::GStreamerHolePunchQuirkWesteros::createHolePunchVideoSink): (WebCore::GStreamerHolePunchQuirkWesteros::setHolePunchVideoRectangle): * Source/WebCore/platform/gstreamer/GStreamerHolePunchQuirkWesteros.h: Added. * Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp: Added. (WebCore::GStreamerQuirkAmLogic::GStreamerQuirkAmLogic): (WebCore::GStreamerQuirkAmLogic::createWebAudioSink): (WebCore::GStreamerQuirkAmLogic::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.h: Added. * Source/WebCore/platform/gstreamer/GStreamerQuirkBcmNexus.cpp: Added. (WebCore::GStreamerQuirkBcmNexus::GStreamerQuirkBcmNexus): (WebCore::GStreamerQuirkBcmNexus::isHardwareAccelerated): * Source/WebCore/platform/gstreamer/GStreamerQuirkBcmNexus.h: Added. * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.cpp: Added. (WebCore::GStreamerQuirkBroadcom::GStreamerQuirkBroadcom): (WebCore::GStreamerQuirkBroadcom::configureElement): (WebCore::GStreamerQuirkBroadcom::isHardwareAccelerated): * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h: Added. * Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.cpp: Added. (WebCore::GStreamerQuirkRealtek::GStreamerQuirkRealtek): (WebCore::GStreamerQuirkRealtek::createWebAudioSink): (WebCore::GStreamerQuirkRealtek::configureElement): (WebCore::GStreamerQuirkRealtek::isHardwareAccelerated): * Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.h: Added. * Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp: Added. (WebCore::GStreamerQuirkWesteros::GStreamerQuirkWesteros): (WebCore::GStreamerQuirkWesteros::configureElement): (WebCore::GStreamerQuirkWesteros::isHardwareAccelerated): * Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.h: Added. * Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp: Added. (WebCore::GStreamerQuirksManager::singleton): (WebCore::GStreamerQuirksManager::GStreamerQuirksManager): (WebCore::GStreamerQuirksManager::isEnabled const): (WebCore::GStreamerQuirksManager::createWebAudioSink): (WebCore::GStreamerQuirksManager::createHolePunchVideoSink): (WebCore::GStreamerQuirksManager::setHolePunchVideoRectangle): (WebCore::GStreamerQuirksManager::configureElement): (WebCore::GStreamerQuirksManager::isHardwareAccelerated const): (WebCore::GStreamerQuirksManager::supportsVideoHolePunchRendering const): (WebCore::GStreamerQuirksManager::audioVideoDecoderFactoryListType const): (WebCore::GStreamerQuirksManager::disallowedWebAudioDecoders const): * Source/WebCore/platform/gstreamer/GStreamerQuirks.h: Added. (WebCore::GStreamerQuirk::isPlatformSupported const): (WebCore::GStreamerQuirk::createWebAudioSink): (WebCore::GStreamerQuirk::configureElement): (WebCore::GStreamerQuirk::isHardwareAccelerated): (WebCore::GStreamerQuirk::audioVideoDecoderFactoryListType const): (WebCore::GStreamerQuirk::disallowedWebAudioDecoders const): (WebCore::GStreamerHolePunchQuirk::createHolePunchVideoSink): (WebCore::GStreamerHolePunchQuirk::setHolePunchVideoRectangle): * Source/cmake/OptionsWPE.cmake:

Backport of https://commits.webkit.org/276450@main keeping old ifdefs compatibility, so the GStreamerQuirksManager::getAdditionalPlaybinFlags() implementation diverges from upstream version.

Downstream GStreamer is already patched for playbin3 decoder/sink handling.

modeveci · 2024-03-29T08:12:35Z

@emutavchi , Once you approved this PR, then I think we are ready to merge. @philn let's wait Eugene's approval and then we can continue.

https://bugs.webkit.org/show_bug.cgi?id=271697 Reviewed by NOBODY (OOPS!). On some platforms it is desirable to apply that quirk unconditionally, because multiple platform-specific quirks are requested. * Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp: (WebCore::GStreamerQuirkAmLogic::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.h: * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.cpp: (WebCore::GStreamerQuirkBroadcom::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h: * Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.cpp: (WebCore::GStreamerQuirkRealtek::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.h: * Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp: (WebCore::GStreamerQuirkWesteros::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.h: * Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp: (WebCore::GStreamerQuirksManager::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirks.h: (WebCore::GStreamerQuirk::configureElement):

https://bugs.webkit.org/show_bug.cgi?id=271751 Reviewed by NOBODY (OOPS!). Allow the decoder pipeline to skip auto-plugging of hardware-accelerated decoders and also to disable parsing, both for Broadcom and Realtek quirks. * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h: * Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.h: * Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp: (WebCore::GStreamerQuirksManager::shouldParseIncomingLibWebRTCBitStream const): * Source/WebCore/platform/gstreamer/GStreamerQuirks.h: (WebCore::GStreamerQuirk::shouldParseIncomingLibWebRTCBitStream const): * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp: (WebCore::GStreamerWebRTCVideoDecoder::getGstAutoplugSelectResult): (WebCore::H264Decoder::H264Decoder):

emutavchi

Looks good to me

https://bugs.webkit.org/show_bug.cgi?id=271308 Reviewed by Xabier Rodriguez-Calvar. The USE_GSTREAMER_TEXT_SINK and USE_GSTREAMER_NATIVE_{AUDIO,VIDEO} ifdefs were replaced with runtime quirks. This patch also includes changes requested in #1297. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::setPlaybackFlags): (WebCore::MediaPlayerPrivateGStreamer::createVideoSink): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: (WebCore::MediaPlayerPrivateGStreamer::pipeline const): * Source/WebCore/platform/gstreamer/GStreamerHolePunchQuirkWesteros.cpp: (WebCore::GStreamerHolePunchQuirkWesteros::createHolePunchVideoSink): * Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp: (WebCore::GStreamerQuirkAmLogic::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h: * Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp: (WebCore::GStreamerQuirksManager::getAdditionalPlaybinFlags const): * Source/WebCore/platform/gstreamer/GStreamerQuirks.h: (WebCore::GStreamerQuirk::getAdditionalPlaybinFlags const): * Source/cmake/GStreamerDefinitions.cmake: Canonical link: https://commits.webkit.org/276450@main

philn added the wpe-2.38 label Mar 11, 2024

philn force-pushed the wpe-2.38-quirks branch 2 times, most recently from a4cac78 to 071ee86Compare March 12, 2024 09:49

philn marked this pull request as ready for review March 13, 2024 09:55

modeveci requested review from emutavchi and modeveci March 13, 2024 12:32

emutavchi reviewed Mar 19, 2024
View reviewed changes

Comment threadSource/WebCore/platform/gstreamer/GStreamerQuirks.h Outdated
Comment threadSource/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp Outdated

emutavchi reviewed Mar 19, 2024
View reviewed changes

Comment threadSource/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp Outdated
Comment threadSource/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp Outdated

emutavchi reviewed Mar 19, 2024
View reviewed changes

Comment threadSource/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Outdated

philn mentioned this pull request Mar 20, 2024
[GStreamer][Quirks] Address review feedback from downstream users WebKit/WebKit#26183
Merged

philn force-pushed the wpe-2.38-quirks branch from 7012c58 to a5fd98eCompare March 21, 2024 10:09

philn requested a review from emutavchi March 21, 2024 10:12

calvaris requested changes Mar 21, 2024
View reviewed changes

Comment threadSource/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp Outdated

philn requested a review from calvaris March 21, 2024 13:33

calvaris approved these changes Mar 21, 2024
View reviewed changes

emutavchi requested changes Mar 25, 2024
View reviewed changes

Comment threadSource/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.cpp Outdated
Comment threadSource/WebCore/platform/gstreamer/GStreamerQuirkRealtek.cpp Outdated
Comment threadSource/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp Outdated

philn added 5 commits March 27, 2024 09:03

Quirks: Fix build after backporting
43daf5d

Quirks: Allow legacy platform ifdefs
6417045

Quirks: Fix hole-punch rendering
e5cace2

Quirks: Fix non-hole punch rendering
3c9f4f1

philn added 10 commits March 27, 2024 09:04

Quirks: Add fakevideosink hole-punch quirk
ee59579

Quirks: set video rectangle even if no platform quirk is requested
473c324

Quirks: Fix debug build
c181765

Quirks: Fix fake hole-punching
4f2974a

Quirks: Fix build
754f3b0

Quirks: Add plumbing for hole-punch testing
8dbe2a3

Quirks: Add quirk for sink clock sync'ing
0141bf9

Quirks: Review feedback changes
dd24e19

Quirks: Address review feedback
971037d
Backport of https://commits.webkit.org/276450@main keeping old ifdefs compatibility, so the GStreamerQuirksManager::getAdditionalPlaybinFlags() implementation diverges from upstream version.

Quirks: Westeros: Remove uridecodebin3 configuration
6bac194
Downstream GStreamer is already patched for playbin3 decoder/sink handling.

philn force-pushed the wpe-2.38-quirks branch from b49989a to 6bac194Compare March 27, 2024 09:06

philn added 2 commits March 29, 2024 09:58

philn requested a review from emutavchi March 29, 2024 10:41

emutavchi approved these changes Mar 29, 2024
View reviewed changes

philn merged commit 99973c6 into wpe-2.38Mar 29, 2024

philn deleted the wpe-2.38-quirks branch March 29, 2024 14:34

Navigation Menu

Uh oh!

Wpe 2.38 quirks - #1297

Wpe 2.38 quirks#1297
philn merged 17 commits into
wpe-2.38from
wpe-2.38-quirks

philn commented Mar 11, 2024

Uh oh!

philn commented Mar 13, 2024

Uh oh!

philn commented Mar 13, 2024

Uh oh!

emutavchi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philn commented Mar 20, 2024

Uh oh!

philn commented Mar 21, 2024

Uh oh!

Uh oh!

calvaris left a comment

Uh oh!

emutavchi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

modeveci commented Mar 29, 2024

Uh oh!

emutavchi left a comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

philn commented Mar 11, 2024

Uh oh!

philn commented Mar 13, 2024

Uh oh!

philn commented Mar 13, 2024

Uh oh!

emutavchi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philn commented Mar 20, 2024

Uh oh!

philn commented Mar 21, 2024

Uh oh!

Uh oh!

calvaris left a comment

Choose a reason for hiding this comment

Uh oh!

emutavchi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

modeveci commented Mar 29, 2024

Uh oh!

emutavchi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants