Comcast modifications

[emutavchi]

I haven't tried this with WPE, so it may be specific to qtwebkit we use. Please review.

[philn]

This won't compile, needs to be WTF::GMutexLocker lock(....)

[philn]

include WTF's GMutexLocker.h header, then WTF::GMutexLocker<GMutex> lock(m_....)

[emutavchi]

Done

[philn]

I tested this and I see a bunch of

ERROR webkitmediaplayer MediaPlayerPrivateGStreamerMSE.cpp:1416:setAppendStage: Invalid append stage transition Ongoing --> Ongoing

now. The state machine needs fixing.

[philn]

Is the setAppendStage error fixed in this new version?

[emutavchi]

Yes, the 'Ongoing --> Ongoing' is fixed. Previous pull request missed some changes, this one should be ok.

[philn]

Please put this in a ifdef

[emutavchi]

Could you please suggest the define to hide this under.

[emutavchi]

WPE_BACKEND is not available in WebCore and WPE_BACKEND_BCM_NEXUS is defined only for WPE module, changing that seems to be out of current task scope.

[emutavchi]

I can remove this change from pull request so we can proceed with other changes. This patch is needed when brcm decoders limit_buffering is enabled, so you should be good without it.

[philn]

Ok let's remove that patch for now then.
The fix I'm suggesting is to define WTF_PLATFORM_BRCM to 1 during the build, so that you can use #if PLATFORM(BRCM) in the code.

[emutavchi]

Removed.