Uh oh!
There was an error while loading. Please reload this page.
[GStreamer][MSE] HLS.JS improvements - #27
Merged
Merged
Conversation
eocanha
commented
Mar 3, 2016
Member
This patch seems to break Youtube 2016 test "32. PlaybackState". I would need more time to debug the issue in deep, but by now I've found this: The test expects the "loadedmetadata" event to be triggered at some point during the data append. In the unmodified code, it's triggered after the audio data has been appended and before feeding the video data, so the test already finds the right condition when everything has been appended. The event is originally triggered by a HTMLMediaElement.setReadyState(HaveEnoughData) as part of a MediaSource.monitorSourceBuffers() call. I can't see beyond in the backtrace with my current release build. |
emutavchiforce-pushed
the
master
branch
4 times, most recently
from
April 27, 2016 15:32
9a0f554 to
5034ef4Compare
Following tests should succeed: 7. InitialMediaVideoWidth 8. InitialMediaVideoHeight 31. VideoDimension http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2016.html?enablewebm=off&tests=7,8,31
Closed
This was referenced Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without this
hls.js doesn't work properly:
test url: http://test.borovkov.com/hlsjs/
(should show only 1 buffered range at all times)