Uh oh!
There was an error while loading. Please reload this page.
Westeros update and westerossink used for video - #35
Closed
aazamansari wants to merge 5 commits into
Closed
Conversation
aazamansari
commented
Mar 25, 2016
- Adding westerossink support for video playback.
- Adding output mode handling for westeros viewbackend.
- Added code to set position and size in case of HOLE_PUNCH_GSTREAMER
2. Adding output mode handling for westeros viewbackend. 3. Added code to set position and size in case of HOLE_PUNCH_GSTREAMER
| if (videoSinkPad) | ||
| g_signal_connect_swapped(videoSinkPad.get(), "notify::caps", G_CALLBACK(videoSinkCapsChangedCallback), this); | ||
| #endif | ||
| #if USE(WESTEROS_SINK) |
There was a problem hiding this comment.
Can this block be moved to the base class? there's a createVideoSink() method there.
Author
There was a problem hiding this comment.
We use WESTEROS_SINK when HOLE_PUNCH_GSTREAMER=ON and createVideoSink is called whtn HOLE_PUNCH_GSTREAMER=OFF. So moving it to base may not work.
added 2 commits
March 28, 2016 13:49
…AMER for creating westerossink.
philn
commented
Mar 29, 2016
Merged manually. |
Closed
This was referenced Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.