Skip to content

CMakeLists: Find wayland and wayland-egl - #36

Merged
zdobersek merged 1 commit into
WebPlatformForEmbedded:masterfrom
Comcast:kraj/master
Mar 28, 2016
Merged

CMakeLists: Find wayland and wayland-egl#36
zdobersek merged 1 commit into
WebPlatformForEmbedded:masterfrom
Comcast:kraj/master

Conversation

@kraj

@krajkraj commented Mar 25, 2016

Copy link
Copy Markdown

Westeros backend depends on it.

Signed-off-by: Khem Raj raj.khem@gmail.com

Westeros backend depends on it.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
@aazamansari

Copy link
Copy Markdown

This will give build error on our box as in our case westeros is not dependent on waylandegl.
In our case westeros-egl is providing wayland-egl support.

@kraj

kraj commented Mar 25, 2016

Copy link
Copy Markdown
Author

@aazamansari you should fix that in platform Cmake files.

@zdobersek

Copy link
Copy Markdown

LGTM

@zdobersek
zdobersek merged commit 2d2ca0d into WebPlatformForEmbedded:masterMar 28, 2016
zdobersek pushed a commit that referenced this pull request May 22, 2017
https://bugs.webkit.org/show_bug.cgi?id=171942
<rdar://problem/32054234>
Reviewed by Tim Horton.
Source/WebCore:
There are some Unicode characters which don't have any font on the system which can render them.
These characters should be drawn as the .notdef "tofu." This is for security and usability, as
well as what Firefox and Chrome do. However, we still shouldn't draw characters with the
Default_Ignorable_Code_Point property, because this is what CoreText does.
This behavior is also what the Unicode spec recommends: In UTR #36 Unicode Security Considerations:
http://www.unicode.org/reports/tr36/#Recommendations_General
"If there is no available glyph for a character, never show a simple "?" or omit the character."
Also relevant is the Unicode Standard section 5.3 Unknown and MIssing Characters, starting at page
marked 203 in the following: http://www.unicode.org/versions/Unicode9.0.0/ch05.pdf
Tests: fast/text/default-ignorable.html
fast/text/unknown-char-notdef.html
* platform/graphics/WidthIterator.cpp:
(WebCore::characterMustDrawSomething):
LayoutTests:
* fast/text/default-ignorable-expected.html: Added.
* fast/text/default-ignorable.html: Added.
* fast/text/unknown-char-notdef-expected-mismatch.html: Added.
* fast/text/unknown-char-notdef.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@216874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
@aazamansariaazamansari mentioned this pull request Jun 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kraj@aazamansari@zdobersek