Uh oh!
There was an error while loading. Please reload this page.
Fixed assigning HAVE_ENOUGH_DATA to media player - #37
Closed
valbok wants to merge 1 commit into
Closed
Conversation
Fixed MediaSource::monitorSourceBuffers() to prevent assigning HAVE_ENOUGH_DATA to media player which led to send loadeddata event before initialization segment received, and no valid duration, seekable and other attributes returned.
calvaris
commented
Apr 1, 2016
Member
Patch looks ok to me and I think it is safe to merge it, though I'd submit it upstream and see what the Apple folks have to say about it. @eocanha, any comments? |
eocanha
commented
Apr 1, 2016
Member
The patch looks good, but unfortunately breaks test "32. PlaybackState" on the Raspberry Pi 2. :-/ |
philnforce-pushed
the
master
branch
2 times, most recently
from
June 17, 2016 13:48
b4a4f67 to
3f4ede2Compare
Closed
charlie-ht
commented
Nov 7, 2017
Just doing some PR cleaning here, this change didn't get in. The commit seems to immediately contradict the comment above this statement. Do we still want this? |
This was referenced Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed MediaSource::monitorSourceBuffers() to prevent assigning HAVE_ENOUGH_DATA to media player
which led to send loadeddata event before initialization segment received,
and no valid duration, seekable and other attributes returned.