Uh oh!
There was an error while loading. Please reload this page.
Fix for the EME tests crash - #42
Merged
Merged
Conversation
eocanha
commented
Apr 21, 2016
Member
The changes related to MSE seem good. |
| } | ||
| ivBuffer = gst_value_get_buffer(value); | ||
| GST_TRACE_OBJECT(self, "decrypting"); |
There was a problem hiding this comment.
I don't see the point of this one. It will "pollute" the trace logs during playback, imho :)
philn
commented
Apr 21, 2016
That GST_TRACE statement can be removed later on, not a blocker for this patch. |
calvaris
commented
Apr 21, 2016
MemberAuthor
They can be removed, but it would be even more useful if they were compiled out when releasing anything. |
philn
commented
Apr 21, 2016
yes, GST_DEBUG can be entirely disabled in gstreamer core, for production builds. |
This was referenced Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.