Skip to content

STM Backend support - #57

Merged
zdobersek merged 20 commits into
WebPlatformForEmbedded:masterfrom
psivasubramanian:master
May 26, 2016
Merged

STM Backend support#57
zdobersek merged 20 commits into
WebPlatformForEmbedded:masterfrom
psivasubramanian:master

Conversation

@psivasubramanian

@psivasubramanianpsivasubramanian commented May 23, 2016

Copy link
Copy Markdown

This request addresses the review comments of pull -#40

philn
philn reviewed May 23, 2016
View reviewed changes
Comment threadSource/cmake/OptionsWPE.cmake Outdated
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATABASE_PROCESS PRIVATE ON)

@philnphilnMay 23, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file seem unrelated to the patch. Please make sure you base your branch on top of current WPE master.

@psivasubramanianpsivasubramanianMay 23, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed by rebasing files.

zdobersek
zdobersek reviewed May 23, 2016
View reviewed changes
Comment threadSource/WPE/CMakeLists.txt Outdated
)
list(APPEND WPE_SOURCES
Source/Graphics/STM/RenderingBackendSTM.cpp
Source/Graphics/RenderingBackend.cpp

@zdobersekzdobersekMay 23, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this line, the file is already included in the list on line 114.

@psivasubramanian

psivasubramanian commented May 24, 2016

Copy link
Copy Markdown
Author

@zdobersek
Incorporated all your review comments.

@zdobersek

zdobersek commented May 26, 2016

Copy link
Copy Markdown

Looks OK, thanks for the updates.

@zdobersek
zdobersek merged commit 4d8dfde into WebPlatformForEmbedded:masterMay 26, 2016
@psivasubramanian

psivasubramanian commented May 26, 2016

Copy link
Copy Markdown
Author

Thanks @zdobersek

@psivasubramanianpsivasubramanian mentioned this pull request May 26, 2016
Closed
@armcc

armcc commented May 27, 2016

Copy link
Copy Markdown

This breaks non-Wayland nexus builds:

| In file included from /.../0.1+gitAUTOINC+30f856124f-r0/git/Source/WPE/Source/Graphics/RenderingBackend.cpp:32:0: | /.../0.1+gitAUTOINC+30f856124f-r0/git/Source/WPE/Source/Graphics/STM/RenderingBackendSTM.h:5:25: fatal error: wayland-egl.h: No such file or directory | compilation terminated.

Shouldn't inclusion of the header files for each backend be conditional on the associated backend being enabled?

@psivasubramanian

psivasubramanian commented May 30, 2016

Copy link
Copy Markdown
Author

Thanks @albertd

@blino

blino commented Aug 1, 2016

Copy link
Copy Markdown

See #79 for the port on new WPE

@pkumbh631pkumbh631 mentioned this pull request Apr 5, 2021
Closed
@asurdej-comcastasurdej-comcast mentioned this pull request Aug 2, 2023
Closed
@tomasz-karczewski-redtomasz-karczewski-red mentioned this pull request Aug 7, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@psivasubramanian@zdobersek@armcc@blino@philn@aazamansari