Allow maxSpinWait option - #57
Draft
WebReflection wants to merge 1 commit into
Draft
WebReflection wants to merge 1 commit into
WebReflection wants to merge 1 commit into
Conversation
WebReflection
force-pushed
the
max-spin-wait
branch
from
May 7, 2025 11:08
4d23136 to
403c100
Compare
Owner
Author
|
TBD should this logic be based on ms instead? would a call to TODO use PyScript tests to measure the impact before landing anything in here |
WebReflection
force-pushed
the
main
branch
15 times, most recently
from
September 18, 2025 08:04
3eee89f to
6873806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR is a ready-to-land amend for the current main branch in case somebody will bring up a compelling reason to actually fallback on
Atomics.wait(view, index)when most use cases expect nearly instant resolution from the main thread.It's true that some task on main could take long time but if it's too long then something is wrong anyway because long tasks, or heavy one, should actually happen in the worker anyway so ... I think we're good the way we are now but ... hey, maybe somebody will find a good reason to have slower waiting logic.