Skip to content

Mentor profile - #49

Open
kasia-filip wants to merge 24 commits into
mainfrom
mentor_profile
Open

Mentor profile#49
kasia-filip wants to merge 24 commits into
mainfrom
mentor_profile

Conversation

@kasia-filip

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlifyBot commented May 22, 2022

Copy link
Copy Markdown

Deploy Preview for brain-code failed.

NameLink
🔨 Latest commit18b9e47
🔍 Latest deploy loghttps://app.netlify.com/sites/brain-code/deploys/628c98cb695fa500098bf601

@TenGosc007TenGosc007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chyba prettier Ci nie działa prawidłowo, zweryfikuj to

Comment threadsrc/App.tsx Outdated
AllTeamProjectsPage,
ContactPage,
EmailVerificationPage,
// EmailVerificationPage,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do usunięcia?

Comment threadsrc/App.tsx Outdated
<Route
path={paths.emailVerification}
element={<PublicRoute {...defaultPublicRouteProps} outlet={<EmailVerificationPage />} />}
// element={<PublicRoute {...defaultPublicRouteProps} outlet={<EmailVerificationPage />} />}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jw, jeśli nie to dodaj TODO

Comment threadsrc/components/Profile/Profile.tsx Outdated
Comment on lines +64 to +67
const [currentNameLang, setCurrentNameLang] = useState();
const [currentLevel, setCurrentLevel] = useState();
const [state, setState] = useState<IProgrammingLanguage>({ nameLang: currentNameLang , level: currentLevel });
const [programmingLanguage, setLanguages] = useState<Array<IProgrammingLanguage>>([]);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

przenieś te hooki wyżej, tam gdzie wywołujesz resztę

Comment on lines +69 to +76
const handleClick = () => {
setState(() => ({
nameLang: currentNameLang,
level: currentLevel,
}));
setLanguages((prevState) => [...prevState, state]);
console.log(programmingLanguage);
};

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wysłałem na dc poprawioną funkcję

Comment threadsrc/components/Profile/Profile.tsx Outdated

const deleteLanguage = (index: number) => {
programmingLanguage.splice(index,1);
console.log(programmingLanguage);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logi do usunięcia

Comment threadsrc/components/Profile/Profile.tsx Outdated
Comment on lines +115 to +117
() => {
navigate(paths.myProfile);
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

() => navigate(paths.myProfile)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

można to zapisać w jednej lini

Comment threadsrc/components/Profile/Profile.tsx Outdated
Comment on lines +122 to +124
() => {
navigate(paths.myProfile);
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jw

Comment threadsrc/components/Profile/validate.ts Outdated
Comment on lines +4 to +6
// const lowercaseRegex = /(?=.*[a-z])/;
// const uppercaseRegex = /(?=.*[A-Z])/;
// const numericRegex = /(?=.*[0-9])/;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do usunięcia lub dodaj TODO

Comment threadsrc/components/Profile/validate.ts Outdated
Comment on lines +13 to +21
// newPassword: Yup.string()
// .matches(lowercaseRegex, t`registration.validation.passwordLow`)
// .matches(uppercaseRegex, t`registration.validation.passwordUpp`)
// .matches(numericRegex, t`registration.validation.passwordNum`)
// .min(8, t`registration.validation.passwordMin`)
// .required(t`registration.validation.passwordReq`),
// confirmNewPassword: Yup.string()
// .oneOf([Yup.ref("newPassword")], t`registration.validation.confirmPassword`)
// .required(t`registration.validation.passwordReq`),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jw

Comment threadsrc/services/user.service.ts Outdated
Comment on lines +13 to +20
// export const getUser= async () => {
// return await axios(`/project/user-projects`, {
// method: "get",
// headers: {
// "x-auth-token": token,
// },
// });
// };

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jw

@kasia-filip

Copy link
Copy Markdown
ContributorAuthor

I've made some changes but, there's still problem with deleting languages - once you have just one language it's ok, but if you have more and attempt to delete a particular one, it will delete more of them - can't figure why.

@kasia-filip

Copy link
Copy Markdown
ContributorAuthor

looks like everything works now :)

@TenGosc007

Copy link
Copy Markdown
Member

zobacz czemu deploy nie działa

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kasia-filip@TenGosc007@WindOfCodes