Conversation
There was a problem hiding this comment.
Pull request overview
Adds a small release-tooling suite to keep VERSION and multiple static manifests in sync, and enforces that synchronization in CI/CD. This also bumps the project/manifest versions to 1.0.0.
Changes:
- Introduce
scripts/release/sync_version.pywith a new--checkmode and a callablesync_static_manifests()API. - Add
scripts/release/bump_version.pyto bumpVERSIONand sync manifests (optionally committing the changes). - Add CI/CD gates for manifest/version sync and add tests covering the bump/sync workflow; update static manifest versions to
1.0.0.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/test_version_scripts.py | Adds tests for the new bump/sync scripts using a temp repo root. |
scripts/release/sync_version.py | Implements manifest synchronization, semver validation, and --check mode for CI/CD enforcement. |
scripts/release/bump_version.py | Adds a CLI to bump VERSION, sync manifests, and optionally commit the resulting changes. |
scripts/release/README.md | Documents the release script commands and suggested release flow. |
.github/workflows/ci.yml | Adds a CI step to verify manifests are synced to VERSION via --check. |
.github/workflows/cd.yml | Replaces ad-hoc sync validation with sync_version.py --check. |
sentinel.skill | Updates manifest version to 1.0.0. |
gemini-extension.json | Updates manifest version to 1.0.0. |
.claude-plugin/plugin.json | Updates manifest version to 1.0.0. |
.agents/plugins/marketplace.json | Updates manifest version to 1.0.0. |
Comments suppressed due to low confidence (2)
scripts/release/sync_version.py:46
read_version()callssys.exit(...)on missing/invalid VERSION. Since this function is now part of the module’s public API (no leading underscore) and is used bysync_static_manifests(), it will terminate the interpreter if someone imports and calls it programmatically. Prefer raising an exception (e.g.,ValueError/FileNotFoundError) and lettingmain()convert that into an exit code/message.
scripts/release/sync_version.py:122- The new
--check/check_onlybehavior is now used in CI/CD, but there are no tests exercising the check path (e.g., out-of-sync manifests should cause a non-zero exit, and in-sync should exit cleanly without writing). Adding a test aroundsync_static_manifests(check_only=True)and/ormain()would help prevent release/CI regressions.
Comment on lines
+67
to
+71
| if not sync_version.is_valid_semver(target): | ||
| raise ValueError( | ||
| f"Invalid version {target!r}. Use semver like 1.0.1 or a bump kind." | ||
| ) | ||
| return target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.