Uh oh!
There was an error while loading. Please reload this page.
Show the frame generation input and output rate on the Mango HUD - #705
Merged
Conversation
FrameRating has shown "30 → 60" since frame generation landed, but the Mango Style HUD only ever showed the game's own rate, so turning frame generation on left its FPS row reading 30 while the panel was presenting 60. Sample the renderer's presented and generated counters the same way FrameRating does, over the same one second window with the same quarter second minimum span, and reuse FrameRating.OutputFrameSource so XServerDisplayActivity hands both HUDs the same source. syncFrameGenerationHud now feeds whichever of the two exists, and runs again when a HUD is created so one turned on mid-session is wired up too. The row keeps the HUD's table layout: the input rate is a right-aligned four-character cell followed by a divider glyph, and the output rate stays in the existing FPS cell, tinted with the same accent FrameRating uses for generated frames. The prefix width is reserved in computeLayoutLocked only while frame generation is producing frames, so columns stay aligned and the panel does not resize per tick. DroidSansMono has no U+2192, so the glyph falls back to "->" when the mono face cannot render the arrow.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FrameRating has shown "30 → 60" since frame generation landed, but the Mango Style HUD only ever showed the game's own rate, so turning frame generation on left its FPS row reading 30 while the panel was presenting 60.
Sample the renderer's presented and generated counters the same way FrameRating does, over the same one second window with the same quarter second minimum span, and reuse FrameRating.OutputFrameSource so XServerDisplayActivity hands both HUDs the same source. syncFrameGenerationHud now feeds whichever of the two exists, and runs again when a HUD is created so one turned on mid-session is wired up too.
The row keeps the HUD's table layout: the input rate is a right-aligned four-character cell followed by a divider glyph, and the output rate stays in the existing FPS cell, tinted with the same accent FrameRating uses for generated frames. The prefix width is reserved in computeLayoutLocked only while frame generation is producing frames, so columns stay aligned and the panel does not resize per tick. DroidSansMono has no U+2192, so the glyph falls back to "->" when the mono face cannot render the arrow.