Uh oh!
There was an error while loading. Please reload this page.
Locate the Lossless DLL with WinNative's file picker - #706
Merged
Conversation
The Locate button on the frame generation card opened Android's document picker, which shows storage through SAF. Lossless.dll lives inside a container's drive_c, and SAF has no view of the imagefs, so reaching it meant copying the DLL out to Downloads first. WinNative already ships a browser that mounts those drives. Open DirectoryPickerDialog.showFile instead, filtered to .dll and given the same C:/Z:/D:/Internal roots the container saves import uses, so the wineprefix is reachable directly. The picker hands back a path rather than a content URI, so add a File overload to LosslessAutoImport.importFrom that goes straight to LosslessScaling.installFrom(Context, File) and skips staging a copy in the cache dir. The reported source name is the containing folder, matching what the automatic Steam import already reports. findActivity moves from private to internal so the Compose card can resolve the host activity the dialog needs.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Locate button on the frame generation card opened Android's document picker, which shows storage through SAF. Lossless.dll lives inside a container's drive_c, and SAF has no view of the imagefs, so reaching it meant copying the DLL out to Downloads first. WinNative already ships a browser that mounts those drives.
Open DirectoryPickerDialog.showFile instead, filtered to .dll and given the same C:/Z:/D:/Internal roots the container saves import uses, so the wineprefix is reachable directly. The picker hands back a path rather than a content URI, so add a File overload to LosslessAutoImport.importFrom that goes straight to LosslessScaling.installFrom(Context, File) and skips staging a copy in the cache dir. The reported source name is the containing folder, matching what the automatic Steam import already reports.
findActivity moves from private to internal so the Compose card can resolve the host activity the dialog needs.