Conversation
pcai
added a commit
that referenced
this pull request
Sep 15, 2026
Reimplement #295 (oauth support by @fliebe92), which had gone conflicted with main. EWSClient.new and Viewpoint::EWS::Connection.new now take an auth hash (endpoint:, type:, user:, password:, token:) instead of positional endpoint, username, password arguments. With type: 'oauth' and a token:, requests carry an Authorization: Bearer header and the basic-auth set_auth handshake is skipped; with type: 'basic' behavior is unchanged. Also fixes a latent bug in the original PR: it called @auth_token.present?, which requires ActiveSupport. The token check is now plain Ruby. Update specs for the new signature, add OAuth header specs, and refresh the README setup docs.
pcai
added a commit
that referenced
this pull request
Sep 15, 2026
Reimplements #295 (oauth support by @fliebe92), which had gone conflicted with main. EWSClient.new and Viewpoint::EWS::Connection.new now take an auth hash (endpoint:, type:, user:, password:, token:) instead of positional endpoint, username, password arguments. With type: 'oauth' and a token:, requests carry an Authorization: Bearer header and the basic-auth set_auth handshake is skipped; with type: 'basic' behavior is unchanged. Also fixes a latent bug in the original PR: it called @auth_token.present?, which requires ActiveSupport. The token check is now plain Ruby.
Contributor
Author
|
Superseded by #305, which reimplements this on current main. |
Contributor
Author
|
@fliebe92 thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #287