Allow providing a custom certificate store - #304
Merged
Merged
Conversation
Add an opt-in :cert_store option to EWS::Connection so callers can pass a fully-built OpenSSL::X509::Store (e.g. one with system default paths) that is assigned directly to the HTTPClient ssl config, skipping the :trust_ca handling. Useful in environments where the default store fails to verify an otherwise valid chain. Add specs covering the passthrough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
:cert_storeoption toViewpoint::EWS::Connection#initialize(also reachable throughEWSClient's:http_opts). When given anOpenSSL::X509::Store, it is assigned directly to the HTTPClient SSL config and the:trust_cahandling is skipped.Why: in some environments the default certificate store fails to verify an otherwise valid chain (e.g.
certificate verify failed (unable to get local issuer certificate)against a Let's Encrypt-issued server cert), leaving monkeypatching as the only recourse. This gives those users a supported escape hatch without changing any default behavior.Supersedes #297, reimplemented from current main.