Validate realm/service options for kerberos transport - #363
Merged
Merged
Conversation
Contributor
Author
|
@sathish-progress thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes kerberos transport validation (reimplements the idea from @sathish-progress in chef/chef-winrm@2ee633b, written fresh against current upstream main).
The
:kerberostransport currently falls through to theelsebranch invalidate_required_fields, demandinguser/password— the wrong options for Kerberos — and producing a cryptic failure deep in the handshake whenrealm/serviceare what is actually needed. This adds an early, clear error:realmandserviceare validated up front for the kerberos transport instead.