Skip to content

Add BattleStations addon - #1816

Merged
z16 merged 3 commits into
Windower:devfrom
Sjshovan:dev
Dec 31, 2019
Merged

Add BattleStations addon#1816
z16 merged 3 commits into
Windower:devfrom
Sjshovan:dev

Conversation

@Sjshovan

@SjshovanSjshovan commented Dec 30, 2019

Copy link
Copy Markdown
Contributor

No description provided.

z16
z16 approved these changes Dec 31, 2019
View reviewed changes

@z16z16 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noted down a few minor comments, most of it looks pretty good. Let me know if you want me to merge it as is or if you want to adjust some of the things I mentioned.

Comment threadaddons/BattleStations/helpers.lua Outdated
Comment threadaddons/addons.xml Outdated
Comment threadaddons/BattleStations/battlestations.lua Outdated
Comment threadaddons/BattleStations/battlestations.lua Outdated
Comment threadaddons/BattleStations/battlestations.lua Outdated
Comment threadaddons/BattleStations/battlestations.lua Outdated
Comment threadaddons/BattleStations/battlestations.lua Outdated
Comment threadaddons/BattleStations/battlestations.lua
@Sjshovan
replace tabs with spaces
f362c9a
remove unnecessary string conversions
remove accidental space character in addons.xml
@Sjshovan

Sjshovan commented Dec 31, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank you for the review. I believe we are ready to merge.

@z16
z16 merged commit 97588bf into Windower:devDec 31, 2019
z16 added a commit that referenced this pull request Nov 4, 2024
@z16
Merge pull request#1816from Ap0gee/dev
baf2809
Add BattleStations addon
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@z16z16z16 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sjshovan@z16