Uh oh!
There was an error while loading. Please reload this page.
Salvage2 Update - #1860
Conversation
Updating local repository
I have restructured parts of Salvage2 so that it uses the new Texts for boxes, and it now works again.
Change textbox method to use Texts, and made other structure adjustments.
Updating local repository
This reverts commit 4554c09.
z16
left a comment
There was a problem hiding this comment.
Hope you appreciate my constructive and detailed code review!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tehkrizz
commented
Apr 10, 2020
@z16 , your feedback is always welcome. Especially when I haven't touched the addons in nearly 2 years. I removed settings.xml from my source and pushed that. I've made the tabs change, but I won't push that one until after my next Salvage run to make sure I didn't screw up a simple find/replace. |
Uh oh!
There was an error while loading. Please reload this page.
Parenthesis and tabs
tehkrizz
commented
Apr 15, 2020
Committed the last of the changes. I included the THTracker parenthesis and tabs as well. |
Updated Salvage2 finally. I used TH Tracker as a baseline since it works. Salvage2 now uses Texts instead of the previous method. for the textboxes, and the settings are structured different. Not sure if it made a difference, but I also adjusted the chat message checks to the format I saw being used. Overall code cleanup as well with the implementation of Texts.
I've done the same thing with DynamisHelper, but it requires a little more testing to ensure it is fully functional again.