Skip to content

Add equipviewer addon - #2013

Merged
z16 merged 21 commits into
Windower:devfrom
RubenatorX:dev
Apr 13, 2021
Merged

Add equipviewer addon#2013
z16 merged 21 commits into
Windower:devfrom
RubenatorX:dev

Conversation

@RubenatorX

@RubenatorXRubenatorX commented Mar 19, 2021

Copy link
Copy Markdown
Collaborator

Still working out a few minor things about crediting people so, don't merge yet but, wanted to get the code review process started. Thank you!

@Chiaia
Chiaia requested a review from z16April 13, 2021 09:28
z16
z16 requested changes Apr 13, 2021
View reviewed changes

@z16z16 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for the most part, some tabs managed to sneak in, and some minor formatting things that I won't bother mentioning in detail. The things I mentioned are all just suggestions for readability or performance.

One thing that must change is an entry in the addons.xml file, otherwise the launcher will not know this addon exists. That is its sole reference, the existence of directories is irrelevant to it.

The other comments I'll leave up to you.

Comment threadaddons/equipviewer/equipviewer.lua Outdated
Comment threadaddons/equipviewer/equipviewer.lua Outdated
Comment threadaddons/equipviewer/equipviewer.lua
Comment threadaddons/equipviewer/equipviewer.lua Outdated
Comment threadaddons/equipviewer/equipviewer.lua Outdated
Comment threadaddons/equipviewer/equipviewer.lua Outdated
Comment threadaddons/equipviewer/equipviewer.lua Outdated
Comment threadaddons/equipviewer/icon_extractor.lua Outdated
Comment threadaddons/equipviewer/icon_extractor.lua Outdated
Comment threadaddons/equipviewer/icon_extractor.lua Outdated
z16
z16 approved these changes Apr 13, 2021
View reviewed changes
@z16
z16 merged commit c6a20d0 into Windower:devApr 13, 2021
z16 added a commit that referenced this pull request Nov 4, 2024
@z16
Merge pull request#2013from RubenatorX/dev
ebcb44e
Add equipviewer addon
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@z16z16z16 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RubenatorX@z16@paulframe