Uh oh!
There was an error while loading. Please reload this page.
[pointwatch] support Master Levels (specifically) - #2170
Conversation
RubenatorX
commented
Mar 13, 2022
The addon does not have a variable for job level, so I'm curious what your argument is for it having master level? |
posimagi
commented
Mar 13, 2022
Several people I've been in groups with have commented that they wished it showed Master Level, or said things such as "I wonder how many Master Levels we've gotten" in longer parties. I wouldn't be opposed to it providing glanceable character level either. |
RubenatorX
commented
Mar 13, 2022
Okay but, levels are not like merit points, to you don't spend them and they are readily available on the equipment or status screen just like masterb levels and you aren't complaining about that. I don't think it should be in the pointeatch defaults for sure. And if it's added as an option, I feel like job level should be added as well. But again, not as a default |
posimagi
commented
Mar 13, 2022
I am happy to add job levels as an option as well, and to leave both as not default. I do realize that all of these values are a few buttons away, but I do think it'd be nice to have the option to display them in the addon. |
posimagi
commented
Mar 13, 2022
posimagi
commented
Mar 16, 2022
Need anything else from me before this is ready to be merged? |
RubenatorX
commented
Mar 16, 2022
Bump the version number. |
posimagi
commented
Mar 21, 2022
I'll bump the version number for now. I'll do the jobs in a separate pull. |
posimagi
commented
Mar 22, 2022
Updated. |
posimagi
commented
Mar 22, 2022
Added jobs. |
posimagi
commented
Mar 22, 2022
| job_map = { |
There was a problem hiding this comment.
Maybe this and the abbreviation map could be pulled from resources instead of a hard-coded mapping?
There was a problem hiding this comment.
It should be, this and the job_abbr_map should be removed and handled via resource lookups. Should also use .name to get language-specific values.
59fca1b to
54621f5Compareposimagi
commented
Mar 24, 2022
Thanks for the comments. I have removed support for job names/abbreviations from this PR and I will submit them separately with the relevant data pulled from resources. Should be good to merge with only the previous functionality included. |
[pointwatch] support Master Levels (specifically)


This diff creates the
ep.master_levelvariable which can be used in pointwatch format strings to display the current job's current Master Level. Note that due to the fact that the incoming packet0x061reports the incorrect Master Level under Level Sync (which is why the game client itself shows the wrong level), this value will also be wrong under Level Sync. While it's certainly possible to hard-code a TNL table to solve this, I've decided to implement the simpler, non-heuristic solution for now. I have also opted not to rock the boat by adding this new value to the default format strings, but I believe that they probably should be added in the future.Example of how this can be used:
