Skip to content

[craft] make bundled recipes higher recipe numbers than their standard equivalents - #2262

Merged
Byrth merged 3 commits into
Windower:devfrom
posimagi:craft-triple-recipes
Jan 19, 2023
Merged

[craft] make bundled recipes higher recipe numbers than their standard equivalents#2262
Byrth merged 3 commits into
Windower:devfrom
posimagi:craft-triple-recipes

Conversation

@posimagi

Copy link
Copy Markdown
Contributor

Move bundled recipes (those that use Bundling Twine, Spindle, etc.) to higher recipe numbers than the standard recipe that makes the basic quantity.

Fix issues with several recipes that erroneously show multiple copies of the bundling guild item.

@posimagi
posimagi marked this pull request as ready for review December 19, 2022 01:33
@posimagi

Copy link
Copy Markdown
ContributorAuthor

Can I get a review on this? Thanks!

@RubenatorX
RubenatorX requested a review from z16January 8, 2023 22:53
@Byrth

Byrth commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Did you make these changes by editing bgwiki and running create_recipes.py?

Recipes are ordered based on the order they show up in bgwiki, because it is just scraping category pages for them. You need to just change the order in the bgwiki crafting category pages and re-run the script to get them into your preferred order. Otherwise your preferred ordering will vanish the next time someone runs the script and updates this.

@posimagi

Copy link
Copy Markdown
ContributorAuthor

Did not know that. I will fix it over there. Thanks.

@Byrth

Copy link
Copy Markdown
Contributor

No problem! Let me know when you update the PR by running create_recipes.py

@posimagi

Copy link
Copy Markdown
ContributorAuthor

So I updated the wiki, ran into a roadblock trying to run the script since it's python2 and I don't have a suitable environment for running it. Decided it might actually be faster to update it to python3 so I'm working on that in a separate feature branch. I'm guessing that was an issue for someone else already since some of the fixes I made manually to recipes.lua were already reflected in the wiki a few months ago despite not being reflected in the addon.

…gh to not break on recipe(s) with unknown ingredients (though the output is not useful--not that it could be crafted anyway).
@posimagi

Copy link
Copy Markdown
ContributorAuthor

Created a separate PR #2267 for the repairs made to the create_recipes.py script (which was not runnable in its current state due to pathological input).

@posimagi
posimagiforce-pushed the craft-triple-recipes branch from 1e4a1e9 to 5d79014CompareJanuary 19, 2023 07:39
…tc.) to higher recipe numbers than the standard recipe that makes the basic quantity. Fix issues with several recipes that erroneously show multiple copies of the bundling guild item.
@posimagi

Copy link
Copy Markdown
ContributorAuthor

This diff will be stacked on top of #2267. Please merge that one first.

@posimagi
posimagiforce-pushed the craft-triple-recipes branch from 5d79014 to 28cbad2CompareJanuary 19, 2023 07:48
@Byrth
Byrth merged commit ff9f951 into Windower:devJan 19, 2023
@posimagi
posimagi deleted the craft-triple-recipes branch January 19, 2023 21:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@posimagi@Byrth