Fix annotation popup when Collect Snapshots is enabled - #4
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughCapture no longer forces annotation mode during testing. The capture flow now follows the configured annotation preference, and the README documents annotation, collection, clipboard, and snapshot storage behavior. ChangesAnnotation-aware capture behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Captures with annotation enabled now open the editor before collection, while unannotated collection behavior remains immediate. The documented workflow and capture behavior are aligned with no remaining merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
When both Collect Snapshots and Annotate Before Copying were enabled, captures silently skipped the annotation editor. Honor the annotation preference first for selection, window, and full-screen captures; the editor can then add the marked-up image to the collection. Captures still collect immediately when annotation is disabled. The capture smoke-test hook now follows saved preferences instead of forcing annotation and masking this conflict. Validation: collection/release tests and universal build passed; a real capture with both saved preferences enabled opened the annotation window with its drawing tools and Add to Collection button.
Summary by CodeRabbit
Bug Fixes
Documentation