Skip to content

Fix annotation popup when Collect Snapshots is enabled - #4

Merged
Wirenut33 merged 1 commit into
mainfrom
codex/fix-annotation-priority
Sep 5, 2026
Merged

Wirenut33 merged 1 commit into
mainfrom
codex/fix-annotation-priority

Conversation

@Wirenut33

@Wirenut33 Wirenut33 commented Sep 5, 2026

Copy link
Copy Markdown
Owner

When both Collect Snapshots and Annotate Before Copying were enabled, captures silently skipped the annotation editor. Honor the annotation preference first for selection, window, and full-screen captures; the editor can then add the marked-up image to the collection. Captures still collect immediately when annotation is disabled. The capture smoke-test hook now follows saved preferences instead of forcing annotation and masking this conflict. Validation: collection/release tests and universal build passed; a real capture with both saved preferences enabled opened the annotation window with its drawing tools and Add to Collection button.

Summary by CodeRabbit

  • Bug Fixes

    • Capture behavior now respects the current annotation setting instead of forcing annotation mode during testing.
    • When annotation is enabled, captures open for editing before collection; when disabled, snapshots are collected or copied directly to the clipboard as appropriate.
  • Documentation

    • Updated snapshot collection guidance to explain annotation-aware capture, Add to Collection, Copy All Snapshots, persistent storage, and clipboard behavior.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: 4cc1a23f-c886-41a1-8599-214570205e46

📥 Commits

Reviewing files that changed from the base of the PR and between 2be2291 and 1fefa6e.

📒 Files selected for processing (2)
  • QuickShot/StatusBarController.swift
  • README.md

Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

Capture no longer forces annotation mode during testing. The capture flow now follows the configured annotation preference, and the README documents annotation, collection, clipboard, and snapshot storage behavior.

Changes

Annotation-aware capture behavior

Layer / File(s) Summary
Capture flow and collection behavior
QuickShot/StatusBarController.swift
capture(_:) no longer accepts forceAnnotation. Annotation mode opens the editor before collection handling. Collection saving remains available when annotation is disabled. Test captures use the configured annotation preference.
Snapshot workflow documentation
README.md
The README documents immediate saves, editor-based markup, Add to Collection, direct clipboard copying, Copy All Snapshots, persistent storage, and Finder access.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 1fefa

Captures with annotation enabled now open the editor before collection, while unannotated collection behavior remains immediate. The documented workflow and capture behavior are aligned with no remaining merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing annotation popups when Collect Snapshots is enabled. It is concise and specific.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-annotation-priority

Comment @coderabbitai help to get the list of available commands.

@Wirenut33
Wirenut33 merged commit 60f2c1c into main Sep 5, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant