chore: keep the ant-node dev-dep on one line - #197
Merged
Merged
Conversation
Closes V2-1033 Formatting only — the dependency is unchanged. The release tooling's rewrite_dep.py handles single-line inline tables only, so the multi-line form introduced in #196 aborts the RC cut with: multi-line inline table for 'ant-node' at line 108 — not supported Collapsing it lets `--rewrite-on ant-core/Cargo.toml#dev-dependencies=ant-node` retarget the pin at cut time, and lets release_one_crate.sh rewrite it back to a published version at promotion. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RAfH7vssjtvHycmbLCr5ov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear issue
Closes V2-1033
What this is
Formatting only. The dependency is byte-for-byte equivalent — same git URL, same rev, same feature.
rewrite_dep.py(the release tooling that retargets internal deps onto rc branches) parses single-line inline tables only. The multi-line form I introduced in #196 aborts the RC cut:Collapsing it lets
--rewrite-on ant-core/Cargo.toml#dev-dependencies=ant-node:...@rc-2026.9.2retarget the pin at cut time, and letsrelease_one_crate.shrewrite it back toant-node = "0.19.0"at promotion. Without this, every future cut that RCs ant-node fails the same way.Risk tier
Compatibility
Semver impact
No version bump; the release train owns that.
Test evidence
Cargo.lockis unchanged by this edit — cargo resolves the two forms identically, which is the proof that it is formatting and not a dependency change. Repo CI covers the rest.New dependency
none
ADR
n/a — T0 formatting change.
Mitigation / rollback
Revert the single commit. That restores the multi-line form, which builds correctly but cannot be processed by the release tooling.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RAfH7vssjtvHycmbLCr5ov