feat(antd-rust): gRPC external-signer prepare/finalize parity with REST - #141
Closed
Nic-dorman wants to merge 1 commit into
Closed
Nic-dorman wants to merge 1 commit into
Nic-dorman wants to merge 1 commit into
Conversation
Adds 7 new methods on `GrpcClient` mirroring the existing REST client surface: * `prepare_upload(path, visibility)` / `prepare_upload_public(path)` * `prepare_data_upload(data, visibility)` * `finalize_upload(upload_id, tx_hashes)` (wave-batch) * `finalize_merkle_upload(upload_id, winner_pool_hash, store_data_map)` * `prepare_chunk_upload(data)` / `finalize_chunk_upload(upload_id, tx_hashes)` All call into the new `UploadService` and the extended `ChunkService` RPCs added on the daemon side. Consumers can now swap a REST `Client` for a `GrpcClient` without code change in the external-signer flow. Proto/build: * `build.rs` picks up `antd/v1/upload.proto`. * `grpc_client.rs` adds the `upload: UploadServiceClient<Channel>` field and constructs it in `connect()`. * Conversion helpers `prepare_response_to_result` / `finalize_response_to_result` / `payment_entry_to_info` map proto3 scalar-default fields back to the REST-style `Option<_>` shape on `PrepareUploadResult` (depth / pool_commitments / merkle_payment_timestamp populated only when `payment_type == "merkle"`). Tests (`grpc_tests.rs`): * Extends `MockChunkService` with `prepare_chunk` (new chunk + already-stored short-circuit) and `finalize_chunk` (echo upload_id). * New `MockUploadService` covers wave-batch, merkle, public/private visibility round-trip via upload_id encoding, and store_data_map true/false. * 12 new `#[tokio::test]` cases covering: - prepare_upload visibility forwarded / omitted - prepare_upload_public convenience wrapper - prepare_data_upload wave-batch / merkle - finalize_upload data_map_address present / absent - finalize_merkle_upload store_data_map true / false - prepare_chunk_upload new / already-stored - finalize_chunk_upload body forwarding 68/68 tests pass on dev2. Depends on the antd-side PR (UploadService + chunks prepare/finalize) to land first so the protos compile against `../antd/proto`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 7 new methods on
GrpcClientmirroring the existing REST client's external-signer surface, so consumers can swap a RESTClientfor aGrpcClientwithout code change in the prepare/finalize flow.Depends on #140 (antd-side
UploadService+ chunks prepare/finalize) — that PR ships the proto + daemon handlers this client calls into.Methods added
prepare_upload(path, visibility)prepare_upload_public(path)visibility = Some("public")prepare_data_upload(data, visibility)finalize_upload(upload_id, tx_hashes)finalize_merkle_upload(upload_id, winner_pool_hash, store_data_map)prepare_chunk_upload(data)finalize_chunk_upload(upload_id, tx_hashes)Implementation notes
upload: UploadServiceClient<Channel>field onGrpcClient, constructed inconnect().build.rspicks upantd/v1/upload.proto.prepare_response_to_result,finalize_response_to_result,payment_entry_to_info) translate proto3 scalar defaults back into the REST-styleOption<_>shape onPrepareUploadResult— merkle-only fields (depth,pool_commitments,merkle_payment_timestamp) are populated only whenpayment_type == "merkle".Tests
MockChunkServicewithprepare_chunk(new + already-stored) andfinalize_chunk(echoes upload_id into address).MockUploadServicecovers wave-batch and merkle response shapes, visibility round-trip via upload_id encoding, andstore_data_maptrue/false branches.#[tokio::test]cases covering visibility omitted/private/public, wave-batch vs merkle,data_map_addresspresence on public, merklestore_data_maptoggle, chunk prepare already-stored short-circuit, and chunk finalize body forwarding.Gates passed on dev2
cargo checkcargo clippy -- -D warningscargo fmt --checkcargo test— 68/68 passingcargo audit— 2 pre-existing upstream warnings, nothing new