feat(deps): react-router v8 migration (fix GHSA-qwww-vcr4-c8h2) - #125
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…grade Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
WolfTasks pushed a commit
that referenced
this pull request
Sep 6, 2026
Ships the react-router v8 migration: - react-router-dom 7.18.1 -> react-router 8.3.1 (#125), which genuinely fixes GHSA-qwww-vcr4-c8h2 (CSRF, CVSS 7.1) instead of suppressing it. The .trivyignore entry and the audit-gate ALLOWLIST are removed again; both gates now run without any exception. - Route-based code-splitting via React.lazy (#126): initial bundle drops from 1,692.35 kB (gzip 501.25) to 832.55 kB (gzip 260.60). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warum
GHSA-qwww-vcr4-c8h2(CSRF, CWE-352, CVSS 7.1) war seit dem 2026-07-29 per.trivyignore+audit-gate.mjs-ALLOWLIST unterdrückt. Die Begründung war korrekt — das CVE betrifft ausschließlich den unstable RSC-Modus, und TaskWolf ist eine reine Client-SPA — aber ein Fix gab es nur in react-router 8.3.0, und das ist ein Major, in demreact-router-domaufgelöst wurde.Dieser PR behebt das CVE echt und entfernt die Unterdrückungen wieder. Umgesetzt nach Plan
docs/superpowers/plans/2026-07-29-react-router-v8-migration-impl.md(PR 1 von 2).Was
14f1939react-router-dom@^7.18.1→react-router@^8.3.1;react-router-domkomplett raus (auch aus dem Lockfile)cd4c826from 'react-router-dom'auffrom 'react-router';RouterProviderinmain.tsxausreact-router/dom(Sonderfall in v8)a26ae2dsetup-node20 → 22 (react-router v8 verlangt Node ≥ 22.22 zur Build-Zeit)532e59e.trivyignore-Block undaudit-gate.mjs-ALLOWLIST entfernt → beide Gates laufen wieder ohne AusnahmeBewusst kein Umbau auf Loader/Actions/Data-Router — die Routen bleiben element-basiert (
element: <Page/>), wir bleiben im Library-Mode mitcreateBrowserRouter+RouterProvider. Reine Security-Migration, minimaler Blast-Radius.Verifikation
npm ci && npx tsc --noEmit)Cannot find module 'react-router-dom'— belegt, dass die Import-Umstellung vollständig sein mussnpx tsc --noEmitundnpm run buildgrün;grep -rn "react-router-dom" src/ohne Treffergrep -c "node_modules/react-router-dom"= 0npm audit --audit-level=high→exit=0, also keine HIGH/CRITICAL mehrnode ../.github/scripts/audit-gate.mjs→ ✅, und die Zeile „Aktive begründete Ausnahmen" ist verschwundenOffen
useMatch) → Board → Issue-Dialog via?issue=(useSearchParams) → Settings-Tabs (Outlet) → Deep-Link/p/:key/issues/:issueKey(useParams).react-router/react-router-dominnerhalb v7) wird hierdurch gegenstandslos → als superseded schließen.🤖 Generated with Claude Code