dev: add `register_ability_args` filter [Proposal] by justlevine · Pull Request #74 · WordPress/abilities-api

justlevine · 2025-09-13T17:03:05Z

What

This PR exposes the register_ability_args filter as a way to centrally extend and change the behavior of registered abilities.

Why

Part of Proposal: Provide extensibility for individual abilities #39
This is a counterproposal to Propose filters to use with the registered ability #37 :
- Placing the filter in WP_Abilities_Registry::register() makes behavior robust against WP_Ability class overloads and keeps the lifecycle + validation intact. In other words: filtering abilities remains idempotent to their non-filtered versions.
- Smaller API footprint (one filter vs several) means smaller chance for future tech debt.
- Arrays continue to be unbeaten when it comes to future backcompat.

How

~~wp_ability_args is used before the merge to core, but it should be changed to abilities_api as part of 6.9 IMO.~~ changed to register_ability_args

Copilot

Pull Request Overview

This PR introduces the wp_ability_args filter to the Abilities API, allowing developers to modify ability arguments before validation and instantiation. This provides a centralized mechanism for extending and customizing ability behavior.

Adds a filter hook in the registry's register method to modify ability arguments
Includes comprehensive documentation with usage examples
Uses wp_ prefix to avoid naming collisions before core integration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
includes/abilities-api/class-wp-abilities-registry.php	Adds the `wp_ability_args` filter in the register method before validation
docs/5.hooks.md	Documents the new filter with detailed usage examples and parameters

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codecov · 2025-09-13T17:05:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.64%. Comparing base (4beab25) to head (36c0e99).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files

@@ Coverage Diff @@## trunk #74 +/- ##
============================================
+ Coverage 84.84% 85.64% +0.79% 
Complexity 102 102 ============================================
Files 16 16 Lines 772 773 +1 Branches 86 86 ============================================
+ Hits 655 662 +7 + Misses 117 111 -6

Flag	Coverage Δ
javascript	`92.66% <ø> (ø)`
unit	`82.88% <100.00%> (+1.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-13T17:17:48Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

gziolo

I left some minor feedback. Overall, I'm very much in favor of the proposed extensibility option.

gziolo · 2025-09-17T08:10:16Z

We will also need some basic unit test coverage to illustrate the expected behavior better and prevent future regressions.

I plan to add some tests today to:

Add execute actions to the ability object #56

We can coordinate how to ensure we avoid more complex merge conflicts.

gziolo · 2025-09-23T10:05:30Z

I plan to add some tests today to:
#56

For your information. Tests for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/tests/unit/abilities-api/wpAbility.php. Docs for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/docs/6.hooks.md.

gziolo · 2025-09-23T10:08:31Z

@galatanovidiu, this proposed filter register_ability_args that allows changing $args during registration should be essential for extenders that want to annotate existing abilities for usage with the MCP adapter when such information is missing.

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-27T20:55:50Z

@gziolo feedback addressed, tests added, and merged the action/filter docs (structure too, not just pasting the two together). PTAL and let me know what you think 🙏

gziolo

Nice addition to the documentation and test coverage. Thank you for addressing my feedback.

I left some small notes to address before merging changes 🚀

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-13T17:03:05Z

What

This PR exposes the register_ability_args filter as a way to centrally extend and change the behavior of registered abilities.

Why

Part of Proposal: Provide extensibility for individual abilities #39
This is a counterproposal to Propose filters to use with the registered ability #37 :
- Placing the filter in WP_Abilities_Registry::register() makes behavior robust against WP_Ability class overloads and keeps the lifecycle + validation intact. In other words: filtering abilities remains idempotent to their non-filtered versions.
- Smaller API footprint (one filter vs several) means smaller chance for future tech debt.
- Arrays continue to be unbeaten when it comes to future backcompat.

How

~~wp_ability_args is used before the merge to core, but it should be changed to abilities_api as part of 6.9 IMO.~~ changed to register_ability_args

Copilot

Pull Request Overview

This PR introduces the wp_ability_args filter to the Abilities API, allowing developers to modify ability arguments before validation and instantiation. This provides a centralized mechanism for extending and customizing ability behavior.

Adds a filter hook in the registry's register method to modify ability arguments
Includes comprehensive documentation with usage examples
Uses wp_ prefix to avoid naming collisions before core integration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
includes/abilities-api/class-wp-abilities-registry.php	Adds the `wp_ability_args` filter in the register method before validation
docs/5.hooks.md	Documents the new filter with detailed usage examples and parameters

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codecov · 2025-09-13T17:05:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.64%. Comparing base (4beab25) to head (36c0e99).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files

@@ Coverage Diff @@## trunk #74 +/- ##
============================================
+ Coverage 84.84% 85.64% +0.79% 
Complexity 102 102 ============================================
Files 16 16 Lines 772 773 +1 Branches 86 86 ============================================
+ Hits 655 662 +7 + Misses 117 111 -6

Flag	Coverage Δ
javascript	`92.66% <ø> (ø)`
unit	`82.88% <100.00%> (+1.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-13T17:17:48Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

gziolo

I left some minor feedback. Overall, I'm very much in favor of the proposed extensibility option.

gziolo · 2025-09-17T08:10:16Z

We will also need some basic unit test coverage to illustrate the expected behavior better and prevent future regressions.

I plan to add some tests today to:

Add execute actions to the ability object #56

We can coordinate how to ensure we avoid more complex merge conflicts.

gziolo · 2025-09-23T10:05:30Z

I plan to add some tests today to:
#56

For your information. Tests for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/tests/unit/abilities-api/wpAbility.php. Docs for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/docs/6.hooks.md.

gziolo · 2025-09-23T10:08:31Z

@galatanovidiu, this proposed filter register_ability_args that allows changing $args during registration should be essential for extenders that want to annotate existing abilities for usage with the MCP adapter when such information is missing.

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-27T20:55:50Z

@gziolo feedback addressed, tests added, and merged the action/filter docs (structure too, not just pasting the two together). PTAL and let me know what you think 🙏

gziolo

Nice addition to the documentation and test coverage. Thank you for addressing my feedback.

I left some small notes to address before merging changes 🚀

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-13T17:03:05Z

What

This PR exposes the register_ability_args filter as a way to centrally extend and change the behavior of registered abilities.

Why

Part of Proposal: Provide extensibility for individual abilities #39
This is a counterproposal to Propose filters to use with the registered ability #37 :
- Placing the filter in WP_Abilities_Registry::register() makes behavior robust against WP_Ability class overloads and keeps the lifecycle + validation intact. In other words: filtering abilities remains idempotent to their non-filtered versions.
- Smaller API footprint (one filter vs several) means smaller chance for future tech debt.
- Arrays continue to be unbeaten when it comes to future backcompat.

How

~~wp_ability_args is used before the merge to core, but it should be changed to abilities_api as part of 6.9 IMO.~~ changed to register_ability_args

Copilot

Pull Request Overview

This PR introduces the wp_ability_args filter to the Abilities API, allowing developers to modify ability arguments before validation and instantiation. This provides a centralized mechanism for extending and customizing ability behavior.

Adds a filter hook in the registry's register method to modify ability arguments
Includes comprehensive documentation with usage examples
Uses wp_ prefix to avoid naming collisions before core integration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
includes/abilities-api/class-wp-abilities-registry.php	Adds the `wp_ability_args` filter in the register method before validation
docs/5.hooks.md	Documents the new filter with detailed usage examples and parameters

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codecov · 2025-09-13T17:05:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.64%. Comparing base (4beab25) to head (36c0e99).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files

@@ Coverage Diff @@## trunk #74 +/- ##
============================================
+ Coverage 84.84% 85.64% +0.79% 
Complexity 102 102 ============================================
Files 16 16 Lines 772 773 +1 Branches 86 86 ============================================
+ Hits 655 662 +7 + Misses 117 111 -6

Flag	Coverage Δ
javascript	`92.66% <ø> (ø)`
unit	`82.88% <100.00%> (+1.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-13T17:17:48Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

gziolo

I left some minor feedback. Overall, I'm very much in favor of the proposed extensibility option.

gziolo · 2025-09-17T08:10:16Z

We will also need some basic unit test coverage to illustrate the expected behavior better and prevent future regressions.

I plan to add some tests today to:

Add execute actions to the ability object #56

We can coordinate how to ensure we avoid more complex merge conflicts.

gziolo · 2025-09-23T10:05:30Z

I plan to add some tests today to:
#56

For your information. Tests for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/tests/unit/abilities-api/wpAbility.php. Docs for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/docs/6.hooks.md.

gziolo · 2025-09-23T10:08:31Z

@galatanovidiu, this proposed filter register_ability_args that allows changing $args during registration should be essential for extenders that want to annotate existing abilities for usage with the MCP adapter when such information is missing.

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-27T20:55:50Z

@gziolo feedback addressed, tests added, and merged the action/filter docs (structure too, not just pasting the two together). PTAL and let me know what you think 🙏

gziolo

Nice addition to the documentation and test coverage. Thank you for addressing my feedback.

I left some small notes to address before merging changes 🚀

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-13T17:03:05Z

What

This PR exposes the register_ability_args filter as a way to centrally extend and change the behavior of registered abilities.

Why

Part of Proposal: Provide extensibility for individual abilities #39
This is a counterproposal to Propose filters to use with the registered ability #37 :
- Placing the filter in WP_Abilities_Registry::register() makes behavior robust against WP_Ability class overloads and keeps the lifecycle + validation intact. In other words: filtering abilities remains idempotent to their non-filtered versions.
- Smaller API footprint (one filter vs several) means smaller chance for future tech debt.
- Arrays continue to be unbeaten when it comes to future backcompat.

How

~~wp_ability_args is used before the merge to core, but it should be changed to abilities_api as part of 6.9 IMO.~~ changed to register_ability_args

Copilot

Pull Request Overview

This PR introduces the wp_ability_args filter to the Abilities API, allowing developers to modify ability arguments before validation and instantiation. This provides a centralized mechanism for extending and customizing ability behavior.

Adds a filter hook in the registry's register method to modify ability arguments
Includes comprehensive documentation with usage examples
Uses wp_ prefix to avoid naming collisions before core integration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
includes/abilities-api/class-wp-abilities-registry.php	Adds the `wp_ability_args` filter in the register method before validation
docs/5.hooks.md	Documents the new filter with detailed usage examples and parameters

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codecov · 2025-09-13T17:05:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.64%. Comparing base (4beab25) to head (36c0e99).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files

@@ Coverage Diff @@## trunk #74 +/- ##
============================================
+ Coverage 84.84% 85.64% +0.79% 
Complexity 102 102 ============================================
Files 16 16 Lines 772 773 +1 Branches 86 86 ============================================
+ Hits 655 662 +7 + Misses 117 111 -6

Flag	Coverage Δ
javascript	`92.66% <ø> (ø)`
unit	`82.88% <100.00%> (+1.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-13T17:17:48Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

gziolo

I left some minor feedback. Overall, I'm very much in favor of the proposed extensibility option.

gziolo · 2025-09-17T08:10:16Z

We will also need some basic unit test coverage to illustrate the expected behavior better and prevent future regressions.

I plan to add some tests today to:

Add execute actions to the ability object #56

We can coordinate how to ensure we avoid more complex merge conflicts.

gziolo · 2025-09-23T10:05:30Z

I plan to add some tests today to:
#56

For your information. Tests for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/tests/unit/abilities-api/wpAbility.php. Docs for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/docs/6.hooks.md.

gziolo · 2025-09-23T10:08:31Z

@galatanovidiu, this proposed filter register_ability_args that allows changing $args during registration should be essential for extenders that want to annotate existing abilities for usage with the MCP adapter when such information is missing.

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-27T20:55:50Z

@gziolo feedback addressed, tests added, and merged the action/filter docs (structure too, not just pasting the two together). PTAL and let me know what you think 🙏

gziolo

Nice addition to the documentation and test coverage. Thank you for addressing my feedback.

I left some small notes to address before merging changes 🚀

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-13T17:03:05Z

What

This PR exposes the register_ability_args filter as a way to centrally extend and change the behavior of registered abilities.

Why

Part of Proposal: Provide extensibility for individual abilities #39
This is a counterproposal to Propose filters to use with the registered ability #37 :
- Placing the filter in WP_Abilities_Registry::register() makes behavior robust against WP_Ability class overloads and keeps the lifecycle + validation intact. In other words: filtering abilities remains idempotent to their non-filtered versions.
- Smaller API footprint (one filter vs several) means smaller chance for future tech debt.
- Arrays continue to be unbeaten when it comes to future backcompat.

How

~~wp_ability_args is used before the merge to core, but it should be changed to abilities_api as part of 6.9 IMO.~~ changed to register_ability_args

Copilot

Pull Request Overview

This PR introduces the wp_ability_args filter to the Abilities API, allowing developers to modify ability arguments before validation and instantiation. This provides a centralized mechanism for extending and customizing ability behavior.

Adds a filter hook in the registry's register method to modify ability arguments
Includes comprehensive documentation with usage examples
Uses wp_ prefix to avoid naming collisions before core integration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
includes/abilities-api/class-wp-abilities-registry.php	Adds the `wp_ability_args` filter in the register method before validation
docs/5.hooks.md	Documents the new filter with detailed usage examples and parameters

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codecov · 2025-09-13T17:05:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.64%. Comparing base (4beab25) to head (36c0e99).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files

@@ Coverage Diff @@## trunk #74 +/- ##
============================================
+ Coverage 84.84% 85.64% +0.79% 
Complexity 102 102 ============================================
Files 16 16 Lines 772 773 +1 Branches 86 86 ============================================
+ Hits 655 662 +7 + Misses 117 111 -6

Flag	Coverage Δ
javascript	`92.66% <ø> (ø)`
unit	`82.88% <100.00%> (+1.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-13T17:17:48Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

gziolo

I left some minor feedback. Overall, I'm very much in favor of the proposed extensibility option.

gziolo · 2025-09-17T08:10:16Z

We will also need some basic unit test coverage to illustrate the expected behavior better and prevent future regressions.

I plan to add some tests today to:

Add execute actions to the ability object #56

We can coordinate how to ensure we avoid more complex merge conflicts.

gziolo · 2025-09-23T10:05:30Z

I plan to add some tests today to:
#56

For your information. Tests for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/tests/unit/abilities-api/wpAbility.php. Docs for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/docs/6.hooks.md.

gziolo · 2025-09-23T10:08:31Z

@galatanovidiu, this proposed filter register_ability_args that allows changing $args during registration should be essential for extenders that want to annotate existing abilities for usage with the MCP adapter when such information is missing.

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-27T20:55:50Z

@gziolo feedback addressed, tests added, and merged the action/filter docs (structure too, not just pasting the two together). PTAL and let me know what you think 🙏

gziolo

Nice addition to the documentation and test coverage. Thank you for addressing my feedback.

I left some small notes to address before merging changes 🚀

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-13T17:03:05Z

What

This PR exposes the register_ability_args filter as a way to centrally extend and change the behavior of registered abilities.

Why

Part of Proposal: Provide extensibility for individual abilities #39
This is a counterproposal to Propose filters to use with the registered ability #37 :
- Placing the filter in WP_Abilities_Registry::register() makes behavior robust against WP_Ability class overloads and keeps the lifecycle + validation intact. In other words: filtering abilities remains idempotent to their non-filtered versions.
- Smaller API footprint (one filter vs several) means smaller chance for future tech debt.
- Arrays continue to be unbeaten when it comes to future backcompat.

How

~~wp_ability_args is used before the merge to core, but it should be changed to abilities_api as part of 6.9 IMO.~~ changed to register_ability_args

Copilot

Pull Request Overview

This PR introduces the wp_ability_args filter to the Abilities API, allowing developers to modify ability arguments before validation and instantiation. This provides a centralized mechanism for extending and customizing ability behavior.

Adds a filter hook in the registry's register method to modify ability arguments
Includes comprehensive documentation with usage examples
Uses wp_ prefix to avoid naming collisions before core integration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
includes/abilities-api/class-wp-abilities-registry.php	Adds the `wp_ability_args` filter in the register method before validation
docs/5.hooks.md	Documents the new filter with detailed usage examples and parameters

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codecov · 2025-09-13T17:05:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.64%. Comparing base (4beab25) to head (36c0e99).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files

@@ Coverage Diff @@## trunk #74 +/- ##
============================================
+ Coverage 84.84% 85.64% +0.79% 
Complexity 102 102 ============================================
Files 16 16 Lines 772 773 +1 Branches 86 86 ============================================
+ Hits 655 662 +7 + Misses 117 111 -6

Flag	Coverage Δ
javascript	`92.66% <ø> (ø)`
unit	`82.88% <100.00%> (+1.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-13T17:17:48Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

gziolo

I left some minor feedback. Overall, I'm very much in favor of the proposed extensibility option.

gziolo · 2025-09-17T08:10:16Z

We will also need some basic unit test coverage to illustrate the expected behavior better and prevent future regressions.

I plan to add some tests today to:

Add execute actions to the ability object #56

We can coordinate how to ensure we avoid more complex merge conflicts.

gziolo · 2025-09-23T10:05:30Z

I plan to add some tests today to:
#56

For your information. Tests for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/tests/unit/abilities-api/wpAbility.php. Docs for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/docs/6.hooks.md.

gziolo · 2025-09-23T10:08:31Z

@galatanovidiu, this proposed filter register_ability_args that allows changing $args during registration should be essential for extenders that want to annotate existing abilities for usage with the MCP adapter when such information is missing.

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-27T20:55:50Z

@gziolo feedback addressed, tests added, and merged the action/filter docs (structure too, not just pasting the two together). PTAL and let me know what you think 🙏

gziolo

Nice addition to the documentation and test coverage. Thank you for addressing my feedback.

I left some small notes to address before merging changes 🚀

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-13T17:03:05Z

What

This PR exposes the register_ability_args filter as a way to centrally extend and change the behavior of registered abilities.

Why

Part of Proposal: Provide extensibility for individual abilities #39
This is a counterproposal to Propose filters to use with the registered ability #37 :
- Placing the filter in WP_Abilities_Registry::register() makes behavior robust against WP_Ability class overloads and keeps the lifecycle + validation intact. In other words: filtering abilities remains idempotent to their non-filtered versions.
- Smaller API footprint (one filter vs several) means smaller chance for future tech debt.
- Arrays continue to be unbeaten when it comes to future backcompat.

How

~~wp_ability_args is used before the merge to core, but it should be changed to abilities_api as part of 6.9 IMO.~~ changed to register_ability_args

Copilot

Pull Request Overview

This PR introduces the wp_ability_args filter to the Abilities API, allowing developers to modify ability arguments before validation and instantiation. This provides a centralized mechanism for extending and customizing ability behavior.

Adds a filter hook in the registry's register method to modify ability arguments
Includes comprehensive documentation with usage examples
Uses wp_ prefix to avoid naming collisions before core integration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
includes/abilities-api/class-wp-abilities-registry.php	Adds the `wp_ability_args` filter in the register method before validation
docs/5.hooks.md	Documents the new filter with detailed usage examples and parameters

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codecov · 2025-09-13T17:05:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.64%. Comparing base (4beab25) to head (36c0e99).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files

@@ Coverage Diff @@## trunk #74 +/- ##
============================================
+ Coverage 84.84% 85.64% +0.79% 
Complexity 102 102 ============================================
Files 16 16 Lines 772 773 +1 Branches 86 86 ============================================
+ Hits 655 662 +7 + Misses 117 111 -6

Flag	Coverage Δ
javascript	`92.66% <ø> (ø)`
unit	`82.88% <100.00%> (+1.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-13T17:17:48Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

gziolo

I left some minor feedback. Overall, I'm very much in favor of the proposed extensibility option.

gziolo · 2025-09-17T08:10:16Z

We will also need some basic unit test coverage to illustrate the expected behavior better and prevent future regressions.

I plan to add some tests today to:

Add execute actions to the ability object #56

We can coordinate how to ensure we avoid more complex merge conflicts.

gziolo · 2025-09-23T10:05:30Z

I plan to add some tests today to:
#56

For your information. Tests for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/tests/unit/abilities-api/wpAbility.php. Docs for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/docs/6.hooks.md.

gziolo · 2025-09-23T10:08:31Z

@galatanovidiu, this proposed filter register_ability_args that allows changing $args during registration should be essential for extenders that want to annotate existing abilities for usage with the MCP adapter when such information is missing.

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-27T20:55:50Z

@gziolo feedback addressed, tests added, and merged the action/filter docs (structure too, not just pasting the two together). PTAL and let me know what you think 🙏

gziolo

Nice addition to the documentation and test coverage. Thank you for addressing my feedback.

I left some small notes to address before merging changes 🚀

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-13T17:03:05Z

What

This PR exposes the register_ability_args filter as a way to centrally extend and change the behavior of registered abilities.

Why

Part of Proposal: Provide extensibility for individual abilities #39
This is a counterproposal to Propose filters to use with the registered ability #37 :
- Placing the filter in WP_Abilities_Registry::register() makes behavior robust against WP_Ability class overloads and keeps the lifecycle + validation intact. In other words: filtering abilities remains idempotent to their non-filtered versions.
- Smaller API footprint (one filter vs several) means smaller chance for future tech debt.
- Arrays continue to be unbeaten when it comes to future backcompat.

How

~~wp_ability_args is used before the merge to core, but it should be changed to abilities_api as part of 6.9 IMO.~~ changed to register_ability_args

Copilot

Pull Request Overview

This PR introduces the wp_ability_args filter to the Abilities API, allowing developers to modify ability arguments before validation and instantiation. This provides a centralized mechanism for extending and customizing ability behavior.

Adds a filter hook in the registry's register method to modify ability arguments
Includes comprehensive documentation with usage examples
Uses wp_ prefix to avoid naming collisions before core integration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
includes/abilities-api/class-wp-abilities-registry.php	Adds the `wp_ability_args` filter in the register method before validation
docs/5.hooks.md	Documents the new filter with detailed usage examples and parameters

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codecov · 2025-09-13T17:05:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.64%. Comparing base (4beab25) to head (36c0e99).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files

@@ Coverage Diff @@## trunk #74 +/- ##
============================================
+ Coverage 84.84% 85.64% +0.79% 
Complexity 102 102 ============================================
Files 16 16 Lines 772 773 +1 Branches 86 86 ============================================
+ Hits 655 662 +7 + Misses 117 111 -6

Flag	Coverage Δ
javascript	`92.66% <ø> (ø)`
unit	`82.88% <100.00%> (+1.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-13T17:17:48Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

gziolo

I left some minor feedback. Overall, I'm very much in favor of the proposed extensibility option.

gziolo · 2025-09-17T08:10:16Z

We will also need some basic unit test coverage to illustrate the expected behavior better and prevent future regressions.

I plan to add some tests today to:

Add execute actions to the ability object #56

We can coordinate how to ensure we avoid more complex merge conflicts.

gziolo · 2025-09-23T10:05:30Z

I plan to add some tests today to:
#56

For your information. Tests for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/tests/unit/abilities-api/wpAbility.php. Docs for hooks live in https://github.com/WordPress/abilities-api/blob/trunk/docs/6.hooks.md.

gziolo · 2025-09-23T10:08:31Z

@galatanovidiu, this proposed filter register_ability_args that allows changing $args during registration should be essential for extenders that want to annotate existing abilities for usage with the MCP adapter when such information is missing.

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

justlevine · 2025-09-27T20:55:50Z

@gziolo feedback addressed, tests added, and merged the action/filter docs (structure too, not just pasting the two together). PTAL and let me know what you think 🙏

gziolo

Nice addition to the documentation and test coverage. Thank you for addressing my feedback.

I left some small notes to address before merging changes 🚀

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

dev: add wp_ability_args filter
eb16f47

justlevine requested a review from Copilot September 13, 2025 17:03

CopilotAI reviewed Sep 13, 2025
View reviewed changes

Comment threaddocs/5.hooks.md Outdated
Comment threaddocs/5.hooks.md Outdated
Comment threaddocs/5.hooks.md Outdated

justlevineand others added 2 commits September 13, 2025 20:10

Update docs/5.hooks.md
15664a3
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

docs: fix has_permissions overload example
dc10954

justlevine requested a review from gziolo September 13, 2025 17:16

justlevine marked this pull request as ready for review September 13, 2025 17:17

justlevine mentioned this pull request Sep 13, 2025
Proposal: Provide extensibility for individual abilities #39
Closed

gziolo reviewed Sep 15, 2025
View reviewed changes

Comment threadincludes/abilities-api/class-wp-abilities-registry.php Outdated
Comment threaddocs/5.hooks.md Outdated
Comment threaddocs/5.hooks.md Outdated

gziolo assigned justlevine Sep 15, 2025

gziolo added the [Type] Enhancement New feature or request label Sep 15, 2025

gziolo mentioned this pull request Sep 22, 2025
Proposal: Add a convienient way to filter the list of all registered abilities #38
Open

gziolo changed the title ~~dev: add wp_ability_args filter [Proposal]~~dev: add register_ability_args filter [Proposal]Sep 23, 2025

gziolo requested a review from galatanovidiu September 23, 2025 10:07

gziolo mentioned this pull request Sep 24, 2025
Major Refactor: Enhanced Transport Infrastructure, Default Server, and CLI Support WordPress/mcp-adapter#48
Merged

justlevineand others added 6 commits September 27, 2025 23:01

Merge branch 'trunk' into dev/wp_ability_args-filter
ad0dfca

fix: rename/relocate filter and fix docs usage
93439d8
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

docs: update remaining references
bcd7ed7

docs: merge hook docs
0c18f42

docs: code indentation
19c9013

tests: add PHPUnit tests for register_ability_args
cef858d

justlevine requested a review from gziolo September 27, 2025 20:55

gziolo approved these changes Sep 29, 2025
View reviewed changes

Comment threaddocs/6.hooks.md Outdated
Comment threadtests/unit/abilities-api/wpAbilitiesRegistry.php Outdated
Comment threadtests/unit/abilities-api/wpAbilitiesRegistry.php Outdated

Update docs/6.hooks.md
cecb83b
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

tests: remove prior filters in _every_ setup/teardown
36c0e99

justlevine requested a review from gziolo September 29, 2025 11:17

gziolo merged commit 309f5a0 into WordPress:trunkSep 29, 2025
22 checks passed

gziolo mentioned this pull request Oct 7, 2025
Propose filters to use with the registered ability #37
Closed