Skip to content

Clean up RmStepRunner and its tests - #95

Merged
adamziel merged 1 commit into
WordPress:trunkfrom
reimic:rmstep
Mar 28, 2024
Merged

Clean up RmStepRunner and its tests#95
adamziel merged 1 commit into
WordPress:trunkfrom
reimic:rmstep

Conversation

@reimic

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • removes the try / catch block from the RmStepRunner
  • renames some variables in the test class for better readability and to match linting standards

What problem does it fix?

How to test if it works?

  • this PR includes tests for RmStepRunner
  • all tests should pass for all supported PHP versions

 - the runner won't catch IOExceptions
- some variables in the test were renamed for better readability and to match linting standards
@reimicreimic self-assigned this Mar 27, 2024
@adamziel
adamziel merged commit 425106c into WordPress:trunkMar 28, 2024
@reimic
reimic deleted the rmstep branch March 28, 2024 11:13
@reimic
reimic restored the rmstep branch April 4, 2024 15:42
@reimic
reimic deleted the rmstep branch April 4, 2024 15:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@reimic@adamziel