Uh oh!
There was an error while loading. Please reload this page.
Stop stripping new lines and instead make parsed post types post_content private - #173
Open
lkwdwrd wants to merge 7 commits into
Open
Stop stripping new lines and instead make parsed post types post_content private#173lkwdwrd wants to merge 7 commits into
lkwdwrd wants to merge 7 commits into
Conversation
lkwdwrd
commented
Jan 8, 2016
ContributorAuthor
Initial pass at a patch for DevHub posted on Meta Trac (https://meta.trac.wordpress.org/ticket/1508) |
DrewAPicture
commented
Jan 14, 2016
Member
Kind of meta, but the |
lkwdwrd
commented
Jan 15, 2016
ContributorAuthor
haha! so very true! I will add one when I find some more time to work on the parser. |
coffee2code added a commit
that referenced
this pull request
Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where new lines were being stripped from
<pre>blocks.Stripping new lines was a bandaid fix to begin with, and bled through in
<pre>blocks. Rather than putting a bandaid over a bandaid, this changes the approach. At the same time we look to grab additional data from the parsing. Namely the raw summary and the raw docblock itself.This is a replacement for the work in #165 which was the bandaid/bandaid fix, but the issue has more history.