Uh oh!
There was an error while loading. Please reload this page.
Patch for track ticket 42724 - #10
Closed
RavanH wants to merge 2 commits into
Closed
Conversation
circlecube pushed a commit
to circlecube/wordpress-develop
that referenced
this pull request
Aug 19, 2021
…-revisions migrate revisions colors to custom properties
anton-vlasenko pushed a commit
to anton-vlasenko/wordpress-develop
that referenced
this pull request
May 26, 2022
blitzyBot
pushed a commit
to Blitzy-Sandbox/blitzy-wordpress
that referenced
this pull request
Jul 8, 2026
Resolves all 24 findings from the FINAL full-project review (docs/index.md boundary). Every fix preserves byte-identical functional output, public APIs, hook contracts, REST routes/schemas, and enqueue semantics (minimal-diff, evidence-first). Code fixes (implemented): - F-005 (CRITICAL, #3): cache-first/batch-primed prepare_item_for_response in class-wp-rest-posts-controller.php matching the passing sibling controllers; fixed a discovered attachment cache-key collision by scoping the media slice under object_type 'attachment-media' (281 posts + 129 attachment tests pass). - F-006 (WordPress#12): registered-handle memoization (get_registered_handles, count-snapshot self-healing) in class-wp-dependencies.php (340 tests pass). - F-003 (WordPress#9): WP_Metadata_Lazyloader $settings expanded to 'post'/'user' (additive; reachable via queue_objects()). - Observability (CRITICAL, #1): install_mu_plugins() wires server-timing.php + clear-cache.php into the benchmark runtime in run-baseline.sh/run-optimized.sh. - Reproducibility (CRITICAL, #2): committed representative raw inputs (before/after JSON) + fail-loud missing-baseline guard in generate-diff-report.js; report regenerates byte-identically. - Quality gate (CRITICAL, WordPress#5): refactored two no-nested-ternary JS-lint errors into a formatSignificantLabel() helper (the alleged PHPStan error was empirically non-reproducible; composer phpstan is green). - KPI 3 (WordPress#6): clarified the admin.test.js instrument as runtime browser-measured gzipped transfer (PerformanceResourceTiming.transferSize); honestly NOT met (17.97%), delivered via F-007 conditional loading. - Accessibility (WordPress#21): prefers-reduced-motion accommodation in the reveal.js deck (Rule-4 verbatim settings preserved). Documented Rule-2 deviations (files intentionally unchanged, with rationale): - WordPress#4 F-009 webpack splitting (DEV-03): admin JS is Grunt-uglified; webpack emits only 4 independent media bundles; splitChunks would break the enqueue graph for zero KPI benefit. development.js split-disable is correct. - WordPress#7 default-filters.php (DEV-04): AAP target mandates "465 registrations preserved"; deferral violates hook-contract preservation. - WordPress#8 class-wp-query.php (DEV-05): memoization/priming is pre-existing WP 6.1+ baseline; F-002 delivered in composed meta-query/wpdb/meta classes. - WordPress#10 general-template.php, WordPress#11 script-loader.php, WordPress#13 ajax-actions.php (DEV-06): no byte-identical-safe, evidence-backed seam at each file's own layer. Documentation honesty rebuild (WordPress#14-WordPress#17, WordPress#19, Rules 1-3): - Rebuilt decision-log-and-traceability.md from git-diff ground truth (correct 10-controller list, accurate per-feature counts, DEV-01..DEV-10, 100% traceability); corrected project-guide.md, technical-specifications.md, index.md, performance-dashboard.md, and the deck to reflect the actual implemented state and baseline-parity gate status. Scope accounting (WordPress#20): three added test files + signatures.php test-alignment (F-003, DEV-10) accounted in traceability §4.3. Build discipline (WordPress#18): grunt build --dev succeeds and dirties zero tracked files (compiled outputs are gitignored). Test evidence (WordPress#19): PHPStan green; PHPCS 0 errors / 0 new warnings (BASE-parity proven); JS lint green; full PHPUnit suite 28994 tests with only 8 pre-existing environmental tzdata failures (deprecated zones absent from container tzdata), all in unchanged files and baseline-identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff submitted on https://core.trac.wordpress.org/ticket/42724