Abilities API: Use stricter `doing_action` check when registering by gziolo · Pull Request #10452 · WordPress/wordpress-develop

gziolo · 2025-11-02T17:29:06Z

Trac ticket: https://core.trac.wordpress.org/ticket/64098

Follow-up for #9410.

Raised by @JasonTheAdams and @felixarntz in WordPress/abilities-api#126 (comment):

I'm curious why we're using did_action() and not doing_action?

I did provide similar feedback somewhere else (I believe on the Core PR) - I think allowing registration at any arbitrary point means we're being "forgiving" to developers doing it wrong, which can then lead to far more obscure problems down the line.
I think clearly defined APIs and, given WordPress's procedural nature, clearly defined registration timing are crucial to avoid more complex problems. Better tell the developer they should fix something rather than them running into a problem later that they have no idea on why it's occurring.

Although the code modifications were simple, getting the unit tests to pass was quite an adventure. I'm still not entirely convinced I took the most elegant approach for simulating the proper conditions, but my focus was to make the tests pass with the minimal set of changes necessary.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-11-02T17:38:14Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gziolo, jorgefilipecosta, flixos90, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-11-02T17:42:02Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

felixarntz

Thanks @gziolo, looks great!

mukeshpanchal27 · 2025-11-03T10:10:42Z

- // Fire the init hook to allow test ability category registration.
- do_action( 'wp_abilities_api_categories_init' );
- wp_register_ability_category(
- 'math',
- array(
- 'label' => 'Math',
- 'description' => 'Mathematical operations and calculations.',
- )
- );
-


Why this is removed?

It isn’t mandatory at this level.

Then remove wp_unregister_ability_category( 'math' ); from tear_down method.

Sure, I’ll look into it.

Feedback applied 👍

Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues. Developed in #10452. Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams. See #64098. git-svn-id: https://develop.svn.wordpress.org/trunk@61130 602fd350-edb4-49c9-b593-d223f7449a82

jorgefilipecosta · 2025-11-04T16:33:59Z

Committed at fd41ccd.

gziolo · 2025-11-02T17:29:06Z

Trac ticket: https://core.trac.wordpress.org/ticket/64098

Follow-up for #9410.

Raised by @JasonTheAdams and @felixarntz in WordPress/abilities-api#126 (comment):

I'm curious why we're using did_action() and not doing_action?

I did provide similar feedback somewhere else (I believe on the Core PR) - I think allowing registration at any arbitrary point means we're being "forgiving" to developers doing it wrong, which can then lead to far more obscure problems down the line.
I think clearly defined APIs and, given WordPress's procedural nature, clearly defined registration timing are crucial to avoid more complex problems. Better tell the developer they should fix something rather than them running into a problem later that they have no idea on why it's occurring.

Although the code modifications were simple, getting the unit tests to pass was quite an adventure. I'm still not entirely convinced I took the most elegant approach for simulating the proper conditions, but my focus was to make the tests pass with the minimal set of changes necessary.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-11-02T17:38:14Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gziolo, jorgefilipecosta, flixos90, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-11-02T17:42:02Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

felixarntz

Thanks @gziolo, looks great!

mukeshpanchal27 · 2025-11-03T10:10:42Z

- // Fire the init hook to allow test ability category registration.
- do_action( 'wp_abilities_api_categories_init' );
- wp_register_ability_category(
- 'math',
- array(
- 'label' => 'Math',
- 'description' => 'Mathematical operations and calculations.',
- )
- );
-


Why this is removed?

It isn’t mandatory at this level.

Then remove wp_unregister_ability_category( 'math' ); from tear_down method.

Sure, I’ll look into it.

Feedback applied 👍

Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues. Developed in #10452. Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams. See #64098. git-svn-id: https://develop.svn.wordpress.org/trunk@61130 602fd350-edb4-49c9-b593-d223f7449a82

jorgefilipecosta · 2025-11-04T16:33:59Z

Committed at fd41ccd.

gziolo · 2025-11-02T17:29:06Z

Trac ticket: https://core.trac.wordpress.org/ticket/64098

Follow-up for #9410.

Raised by @JasonTheAdams and @felixarntz in WordPress/abilities-api#126 (comment):

I'm curious why we're using did_action() and not doing_action?

I did provide similar feedback somewhere else (I believe on the Core PR) - I think allowing registration at any arbitrary point means we're being "forgiving" to developers doing it wrong, which can then lead to far more obscure problems down the line.
I think clearly defined APIs and, given WordPress's procedural nature, clearly defined registration timing are crucial to avoid more complex problems. Better tell the developer they should fix something rather than them running into a problem later that they have no idea on why it's occurring.

Although the code modifications were simple, getting the unit tests to pass was quite an adventure. I'm still not entirely convinced I took the most elegant approach for simulating the proper conditions, but my focus was to make the tests pass with the minimal set of changes necessary.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-11-02T17:38:14Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gziolo, jorgefilipecosta, flixos90, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-11-02T17:42:02Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

felixarntz

Thanks @gziolo, looks great!

mukeshpanchal27 · 2025-11-03T10:10:42Z

- // Fire the init hook to allow test ability category registration.
- do_action( 'wp_abilities_api_categories_init' );
- wp_register_ability_category(
- 'math',
- array(
- 'label' => 'Math',
- 'description' => 'Mathematical operations and calculations.',
- )
- );
-


Why this is removed?

It isn’t mandatory at this level.

Then remove wp_unregister_ability_category( 'math' ); from tear_down method.

Sure, I’ll look into it.

Feedback applied 👍

Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues. Developed in #10452. Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams. See #64098. git-svn-id: https://develop.svn.wordpress.org/trunk@61130 602fd350-edb4-49c9-b593-d223f7449a82

jorgefilipecosta · 2025-11-04T16:33:59Z

Committed at fd41ccd.

gziolo · 2025-11-02T17:29:06Z

Trac ticket: https://core.trac.wordpress.org/ticket/64098

Follow-up for #9410.

Raised by @JasonTheAdams and @felixarntz in WordPress/abilities-api#126 (comment):

I'm curious why we're using did_action() and not doing_action?

I did provide similar feedback somewhere else (I believe on the Core PR) - I think allowing registration at any arbitrary point means we're being "forgiving" to developers doing it wrong, which can then lead to far more obscure problems down the line.
I think clearly defined APIs and, given WordPress's procedural nature, clearly defined registration timing are crucial to avoid more complex problems. Better tell the developer they should fix something rather than them running into a problem later that they have no idea on why it's occurring.

Although the code modifications were simple, getting the unit tests to pass was quite an adventure. I'm still not entirely convinced I took the most elegant approach for simulating the proper conditions, but my focus was to make the tests pass with the minimal set of changes necessary.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-11-02T17:38:14Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gziolo, jorgefilipecosta, flixos90, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-11-02T17:42:02Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

felixarntz

Thanks @gziolo, looks great!

mukeshpanchal27 · 2025-11-03T10:10:42Z

- // Fire the init hook to allow test ability category registration.
- do_action( 'wp_abilities_api_categories_init' );
- wp_register_ability_category(
- 'math',
- array(
- 'label' => 'Math',
- 'description' => 'Mathematical operations and calculations.',
- )
- );
-


Why this is removed?

It isn’t mandatory at this level.

Then remove wp_unregister_ability_category( 'math' ); from tear_down method.

Sure, I’ll look into it.

Feedback applied 👍

Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues. Developed in #10452. Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams. See #64098. git-svn-id: https://develop.svn.wordpress.org/trunk@61130 602fd350-edb4-49c9-b593-d223f7449a82

jorgefilipecosta · 2025-11-04T16:33:59Z

Committed at fd41ccd.

gziolo · 2025-11-02T17:29:06Z

Trac ticket: https://core.trac.wordpress.org/ticket/64098

Follow-up for #9410.

Raised by @JasonTheAdams and @felixarntz in WordPress/abilities-api#126 (comment):

I'm curious why we're using did_action() and not doing_action?

I did provide similar feedback somewhere else (I believe on the Core PR) - I think allowing registration at any arbitrary point means we're being "forgiving" to developers doing it wrong, which can then lead to far more obscure problems down the line.
I think clearly defined APIs and, given WordPress's procedural nature, clearly defined registration timing are crucial to avoid more complex problems. Better tell the developer they should fix something rather than them running into a problem later that they have no idea on why it's occurring.

Although the code modifications were simple, getting the unit tests to pass was quite an adventure. I'm still not entirely convinced I took the most elegant approach for simulating the proper conditions, but my focus was to make the tests pass with the minimal set of changes necessary.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-11-02T17:38:14Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gziolo, jorgefilipecosta, flixos90, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-11-02T17:42:02Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

felixarntz

Thanks @gziolo, looks great!

mukeshpanchal27 · 2025-11-03T10:10:42Z

- // Fire the init hook to allow test ability category registration.
- do_action( 'wp_abilities_api_categories_init' );
- wp_register_ability_category(
- 'math',
- array(
- 'label' => 'Math',
- 'description' => 'Mathematical operations and calculations.',
- )
- );
-


Why this is removed?

It isn’t mandatory at this level.

Then remove wp_unregister_ability_category( 'math' ); from tear_down method.

Sure, I’ll look into it.

Feedback applied 👍

Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues. Developed in #10452. Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams. See #64098. git-svn-id: https://develop.svn.wordpress.org/trunk@61130 602fd350-edb4-49c9-b593-d223f7449a82

jorgefilipecosta · 2025-11-04T16:33:59Z

Committed at fd41ccd.

gziolo · 2025-11-02T17:29:06Z

Trac ticket: https://core.trac.wordpress.org/ticket/64098

Follow-up for #9410.

Raised by @JasonTheAdams and @felixarntz in WordPress/abilities-api#126 (comment):

I'm curious why we're using did_action() and not doing_action?

I did provide similar feedback somewhere else (I believe on the Core PR) - I think allowing registration at any arbitrary point means we're being "forgiving" to developers doing it wrong, which can then lead to far more obscure problems down the line.
I think clearly defined APIs and, given WordPress's procedural nature, clearly defined registration timing are crucial to avoid more complex problems. Better tell the developer they should fix something rather than them running into a problem later that they have no idea on why it's occurring.

Although the code modifications were simple, getting the unit tests to pass was quite an adventure. I'm still not entirely convinced I took the most elegant approach for simulating the proper conditions, but my focus was to make the tests pass with the minimal set of changes necessary.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-11-02T17:38:14Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gziolo, jorgefilipecosta, flixos90, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-11-02T17:42:02Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

felixarntz

Thanks @gziolo, looks great!

mukeshpanchal27 · 2025-11-03T10:10:42Z

- // Fire the init hook to allow test ability category registration.
- do_action( 'wp_abilities_api_categories_init' );
- wp_register_ability_category(
- 'math',
- array(
- 'label' => 'Math',
- 'description' => 'Mathematical operations and calculations.',
- )
- );
-


Why this is removed?

It isn’t mandatory at this level.

Then remove wp_unregister_ability_category( 'math' ); from tear_down method.

Sure, I’ll look into it.

Feedback applied 👍

Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues. Developed in #10452. Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams. See #64098. git-svn-id: https://develop.svn.wordpress.org/trunk@61130 602fd350-edb4-49c9-b593-d223f7449a82

jorgefilipecosta · 2025-11-04T16:33:59Z

Committed at fd41ccd.

gziolo · 2025-11-02T17:29:06Z

Trac ticket: https://core.trac.wordpress.org/ticket/64098

Follow-up for #9410.

Raised by @JasonTheAdams and @felixarntz in WordPress/abilities-api#126 (comment):

I'm curious why we're using did_action() and not doing_action?

I did provide similar feedback somewhere else (I believe on the Core PR) - I think allowing registration at any arbitrary point means we're being "forgiving" to developers doing it wrong, which can then lead to far more obscure problems down the line.
I think clearly defined APIs and, given WordPress's procedural nature, clearly defined registration timing are crucial to avoid more complex problems. Better tell the developer they should fix something rather than them running into a problem later that they have no idea on why it's occurring.

Although the code modifications were simple, getting the unit tests to pass was quite an adventure. I'm still not entirely convinced I took the most elegant approach for simulating the proper conditions, but my focus was to make the tests pass with the minimal set of changes necessary.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-11-02T17:38:14Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gziolo, jorgefilipecosta, flixos90, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-11-02T17:42:02Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

felixarntz

Thanks @gziolo, looks great!

mukeshpanchal27 · 2025-11-03T10:10:42Z

- // Fire the init hook to allow test ability category registration.
- do_action( 'wp_abilities_api_categories_init' );
- wp_register_ability_category(
- 'math',
- array(
- 'label' => 'Math',
- 'description' => 'Mathematical operations and calculations.',
- )
- );
-


Why this is removed?

It isn’t mandatory at this level.

Then remove wp_unregister_ability_category( 'math' ); from tear_down method.

Sure, I’ll look into it.

Feedback applied 👍

Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues. Developed in #10452. Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams. See #64098. git-svn-id: https://develop.svn.wordpress.org/trunk@61130 602fd350-edb4-49c9-b593-d223f7449a82

jorgefilipecosta · 2025-11-04T16:33:59Z

Committed at fd41ccd.

gziolo · 2025-11-02T17:29:06Z

Trac ticket: https://core.trac.wordpress.org/ticket/64098

Follow-up for #9410.

Raised by @JasonTheAdams and @felixarntz in WordPress/abilities-api#126 (comment):

I'm curious why we're using did_action() and not doing_action?

I did provide similar feedback somewhere else (I believe on the Core PR) - I think allowing registration at any arbitrary point means we're being "forgiving" to developers doing it wrong, which can then lead to far more obscure problems down the line.
I think clearly defined APIs and, given WordPress's procedural nature, clearly defined registration timing are crucial to avoid more complex problems. Better tell the developer they should fix something rather than them running into a problem later that they have no idea on why it's occurring.

Although the code modifications were simple, getting the unit tests to pass was quite an adventure. I'm still not entirely convinced I took the most elegant approach for simulating the proper conditions, but my focus was to make the tests pass with the minimal set of changes necessary.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-11-02T17:38:14Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gziolo, jorgefilipecosta, flixos90, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-11-02T17:42:02Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

felixarntz

Thanks @gziolo, looks great!

mukeshpanchal27 · 2025-11-03T10:10:42Z

- // Fire the init hook to allow test ability category registration.
- do_action( 'wp_abilities_api_categories_init' );
- wp_register_ability_category(
- 'math',
- array(
- 'label' => 'Math',
- 'description' => 'Mathematical operations and calculations.',
- )
- );
-


Why this is removed?

It isn’t mandatory at this level.

Then remove wp_unregister_ability_category( 'math' ); from tear_down method.

Sure, I’ll look into it.

Feedback applied 👍

Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues. Developed in #10452. Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams. See #64098. git-svn-id: https://develop.svn.wordpress.org/trunk@61130 602fd350-edb4-49c9-b593-d223f7449a82

jorgefilipecosta · 2025-11-04T16:33:59Z

Committed at fd41ccd.

Abilities API: Use stricter doing_action check when registering
a928fd6

gziolo self-assigned this Nov 2, 2025

gziolo mentioned this pull request Nov 2, 2025
Sync changes from WordPress core after 6.9 beta 1 WordPress/abilities-api#126
Merged

gziolo requested a review from felixarntz November 2, 2025 17:34

gziolo marked this pull request as ready for review November 2, 2025 17:38

felixarntz approved these changes Nov 3, 2025
View reviewed changes

mukeshpanchal27 reviewed Nov 3, 2025
View reviewed changes

remove unrequired category unregister
250a34e

jorgefilipecosta closed this Nov 4, 2025

gziolo deleted the update/use-doing-action-abilities-api branch November 5, 2025 08:06

chubes4 mentioned this pull request Jul 16, 2026
Abilities API: Allow registration after init #12401
Closed

Abilities API: Use stricter doing_action check when registering
a928fd6

gziolo self-assigned this Nov 2, 2025

gziolo mentioned this pull request Nov 2, 2025
Sync changes from WordPress core after 6.9 beta 1 WordPress/abilities-api#126
Merged

gziolo requested a review from felixarntz November 2, 2025 17:34

gziolo marked this pull request as ready for review November 2, 2025 17:38

felixarntz approved these changes Nov 3, 2025
View reviewed changes

mukeshpanchal27 reviewed Nov 3, 2025
View reviewed changes

remove unrequired category unregister
250a34e

jorgefilipecosta closed this Nov 4, 2025

gziolo deleted the update/use-doing-action-abilities-api branch November 5, 2025 08:06

chubes4 mentioned this pull request Jul 16, 2026
Abilities API: Allow registration after init #12401
Closed

Abilities API: Use stricter doing_action check when registering
a928fd6

gziolo self-assigned this Nov 2, 2025

gziolo mentioned this pull request Nov 2, 2025
Sync changes from WordPress core after 6.9 beta 1 WordPress/abilities-api#126
Merged

gziolo requested a review from felixarntz November 2, 2025 17:34

gziolo marked this pull request as ready for review November 2, 2025 17:38

felixarntz approved these changes Nov 3, 2025
View reviewed changes

mukeshpanchal27 reviewed Nov 3, 2025
View reviewed changes

remove unrequired category unregister
250a34e

jorgefilipecosta closed this Nov 4, 2025

gziolo deleted the update/use-doing-action-abilities-api branch November 5, 2025 08:06

chubes4 mentioned this pull request Jul 16, 2026
Abilities API: Allow registration after init #12401
Closed

Abilities API: Use stricter doing_action check when registering
a928fd6

gziolo self-assigned this Nov 2, 2025

gziolo mentioned this pull request Nov 2, 2025
Sync changes from WordPress core after 6.9 beta 1 WordPress/abilities-api#126
Merged

gziolo requested a review from felixarntz November 2, 2025 17:34

gziolo marked this pull request as ready for review November 2, 2025 17:38

felixarntz approved these changes Nov 3, 2025
View reviewed changes

mukeshpanchal27 reviewed Nov 3, 2025
View reviewed changes

remove unrequired category unregister
250a34e

jorgefilipecosta closed this Nov 4, 2025

gziolo deleted the update/use-doing-action-abilities-api branch November 5, 2025 08:06

chubes4 mentioned this pull request Jul 16, 2026
Abilities API: Allow registration after init #12401
Closed

Abilities API: Use stricter doing_action check when registering
a928fd6

gziolo self-assigned this Nov 2, 2025

gziolo mentioned this pull request Nov 2, 2025
Sync changes from WordPress core after 6.9 beta 1 WordPress/abilities-api#126
Merged

gziolo requested a review from felixarntz November 2, 2025 17:34

gziolo marked this pull request as ready for review November 2, 2025 17:38

felixarntz approved these changes Nov 3, 2025
View reviewed changes

mukeshpanchal27 reviewed Nov 3, 2025
View reviewed changes

remove unrequired category unregister
250a34e

jorgefilipecosta closed this Nov 4, 2025

gziolo deleted the update/use-doing-action-abilities-api branch November 5, 2025 08:06

chubes4 mentioned this pull request Jul 16, 2026
Abilities API: Allow registration after init #12401
Closed

Abilities API: Use stricter doing_action check when registering
a928fd6

gziolo self-assigned this Nov 2, 2025

gziolo mentioned this pull request Nov 2, 2025
Sync changes from WordPress core after 6.9 beta 1 WordPress/abilities-api#126
Merged

gziolo requested a review from felixarntz November 2, 2025 17:34

gziolo marked this pull request as ready for review November 2, 2025 17:38

felixarntz approved these changes Nov 3, 2025
View reviewed changes

mukeshpanchal27 reviewed Nov 3, 2025
View reviewed changes

remove unrequired category unregister
250a34e

jorgefilipecosta closed this Nov 4, 2025

gziolo deleted the update/use-doing-action-abilities-api branch November 5, 2025 08:06

chubes4 mentioned this pull request Jul 16, 2026
Abilities API: Allow registration after init #12401
Closed

Abilities API: Use stricter doing_action check when registering
a928fd6

gziolo self-assigned this Nov 2, 2025

gziolo mentioned this pull request Nov 2, 2025
Sync changes from WordPress core after 6.9 beta 1 WordPress/abilities-api#126
Merged

gziolo requested a review from felixarntz November 2, 2025 17:34

gziolo marked this pull request as ready for review November 2, 2025 17:38

felixarntz approved these changes Nov 3, 2025
View reviewed changes

mukeshpanchal27 reviewed Nov 3, 2025
View reviewed changes

remove unrequired category unregister
250a34e

jorgefilipecosta closed this Nov 4, 2025

gziolo deleted the update/use-doing-action-abilities-api branch November 5, 2025 08:06

chubes4 mentioned this pull request Jul 16, 2026
Abilities API: Allow registration after init #12401
Closed

Abilities API: Use stricter doing_action check when registering
a928fd6

gziolo self-assigned this Nov 2, 2025

gziolo mentioned this pull request Nov 2, 2025
Sync changes from WordPress core after 6.9 beta 1 WordPress/abilities-api#126
Merged

gziolo requested a review from felixarntz November 2, 2025 17:34

gziolo marked this pull request as ready for review November 2, 2025 17:38

felixarntz approved these changes Nov 3, 2025
View reviewed changes

mukeshpanchal27 reviewed Nov 3, 2025
View reviewed changes

remove unrequired category unregister
250a34e

jorgefilipecosta closed this Nov 4, 2025

gziolo deleted the update/use-doing-action-abilities-api branch November 5, 2025 08:06

chubes4 mentioned this pull request Jul 16, 2026
Abilities API: Allow registration after init #12401
Closed

Uh oh!

Conversation

gziolo commented Nov 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Nov 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Nov 2, 2025

Test using WordPress Playground

Some things to be aware of

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorgefilipecosta commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

gziolo commented Nov 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Nov 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Nov 2, 2025

Test using WordPress Playground

Some things to be aware of

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorgefilipecosta commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

gziolo commented Nov 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Nov 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Nov 2, 2025

Test using WordPress Playground

gziolo commented Nov 2, 2025•
edited
Loading

github-actionsBot commented Nov 2, 2025•
edited
Loading

gziolo commented Nov 2, 2025•
edited
Loading

github-actionsBot commented Nov 2, 2025•
edited
Loading

gziolo commented Nov 2, 2025•
edited
Loading

github-actionsBot commented Nov 2, 2025•
edited
Loading

gziolo commented Nov 2, 2025•
edited
Loading

github-actionsBot commented Nov 2, 2025•
edited
Loading