Uh oh!
There was an error while loading. Please reload this page.
56694 Reset wp_page_for_privacy_policy when the page is trashed - #11520
Closed
nimesh-xecurify wants to merge 2 commits into
Closed
56694 Reset wp_page_for_privacy_policy when the page is trashed#11520nimesh-xecurify wants to merge 2 commits into
nimesh-xecurify wants to merge 2 commits into
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
commented
Jun 2, 2026
Member
Closing since tests have been moved to #11443. |
pento pushed a commit
that referenced
this pull request
Jul 24, 2026
If the privacy page is deleted but the setting is left intact, an admin_hook would fire on every admin screen attempting to notify about changes in the privacy policy. With the page deleted, this database read is never cached, since it returns no results. Add a `before_delete_post` hook to reset setting if the post is deleted. Add a guard to reset the option on the privacy screen to cover edge cases. Developed in #11443, #11520 Props johnjamesjacoby, masteradhoc, westonruter, nimeshatxecurify, mukesh27, joedolson. Fixes #56694. git-svn-id: https://develop.svn.wordpress.org/trunk@62845 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 24, 2026
If the privacy page is deleted but the setting is left intact, an admin_hook would fire on every admin screen attempting to notify about changes in the privacy policy. With the page deleted, this database read is never cached, since it returns no results. Add a `before_delete_post` hook to reset setting if the post is deleted. Add a guard to reset the option on the privacy screen to cover edge cases. Developed in WordPress/wordpress-develop#11443, WordPress/wordpress-develop#11520 Props johnjamesjacoby, masteradhoc, westonruter, nimeshatxecurify, mukesh27, joedolson. Fixes #56694. Built from https://develop.svn.wordpress.org/trunk@62845 git-svn-id: http://core.svn.wordpress.org/trunk@62125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed tests for #11443
Original author : @masteradhoc
Trac ticket: https://core.trac.wordpress.org/ticket/56694