Uh oh!
There was an error while loading. Please reload this page.
52988: Adds tests for get bookmark - #1180
Conversation
peterwilsoncc
left a comment
There was a problem hiding this comment.
As always, this is lovely.
As always, I've added a few minor questions and comments inline but nothing major.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Why? Performance => factory runs once instead for each test.
peterwilsoncc
left a comment
There was a problem hiding this comment.
This looks good to me.
It looks like there was an accidental change to package-lock.json included in 3111683 but I'll preapprove as it's really the committers responsibility to check against these things.
9b4ff97 to
9fcb19bComparehellofromtonya
commented
Apr 25, 2021
Yup, I did. Doh. Way too easy to accidentally commit lock file. Luckily, it's straightforward for the core committer to skip over that file and only commit the test file. Thanks @peterwilsoncc! |
peterwilsoncc
commented
Apr 26, 2021
Committed as https://core.trac.wordpress.org/changeset/50789 |
Trac ticket: https://core.trac.wordpress.org/ticket/52988
Adds unit tests for
get_bookmark().The tests are broken up by the logic path through the if/elseif/else branches.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.