Uh oh!
There was an error while loading. Please reload this page.
#53611: Fix font size inconsistency in erasure notice list items - #12021
#53611: Fix font size inconsistency in erasure notice list items#12021masteradhoc wants to merge 3 commits into
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
Fixes a typography inconsistency in the wp-admin “widefat” table inline notice used in personal data erasure requests, where list items inside a notice (rendered in a <th>) inherit the wrong font size.
Changes:
- Adds a CSS rule to force
.notice ul liinside.widefattable cells/headers to use the intended smaller font size. - Adjusts list-item line-height and spacing within those scoped notice lists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
src/wp-admin/css/common.css:530
- This rule adds
margin: 0 0.5em;to notice list items inside widefat tables, which changes layout/indentation beyond the font-size/line-height fix described in the PR. If the goal is only to normalize typography for inline notices, consider dropping the margin override to keep the change narrowly scoped.
font-size: 13px;
line-height: 1.54;
margin: 0 0.5em;
src/wp-admin/css/common.css:529
- The PR description indicates
line-height: 1.5emfor this selector, but the implementation usesline-height: 1.54(matching the.notice prule in this file). Please align the PR description (and/or Trac ticket notes) with the actual value to avoid confusion during review/landing.
line-height: 1.54;
joedolson
left a comment
There was a problem hiding this comment.
Approving; will switch the margins in commit.
Uh oh!
There was an error while loading. Please reload this page.
Additional messages can be inserted by plugins using the `wp_privacy_personal_data_erasers` filter, and are generated as list items (`li`) inside the notice markup. However, `li` was not targeted with notice-specific styling, and inherited the list item styles from the containing table. Add additional styles targeting list items inside notices in list tables to equalize font sizes and styling. Developed in #12021 Props kimannwall, masteradhoc, joedolson. Fixes #53611. git-svn-id: https://develop.svn.wordpress.org/trunk@62847 602fd350-edb4-49c9-b593-d223f7449a82
Additional messages can be inserted by plugins using the `wp_privacy_personal_data_erasers` filter, and are generated as list items (`li`) inside the notice markup. However, `li` was not targeted with notice-specific styling, and inherited the list item styles from the containing table. Add additional styles targeting list items inside notices in list tables to equalize font sizes and styling. Developed in WordPress/wordpress-develop#12021 Props kimannwall, masteradhoc, joedolson. Fixes #53611. Built from https://develop.svn.wordpress.org/trunk@62847 git-svn-id: http://core.svn.wordpress.org/trunk@62127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fix font size inconsistency in the data erasure inline notice for list items added via
additionalMessages.The inline notice rendered inside the personal data erasure list table contains a
<p>element followed by a<ul>with plugin-provided messages. The<p>correctly inheritsfont-size: 13pxfrom.notice p, but the<li>elements were inheritingfont-size: 14pxfrom the.widefat thrule, since the notice sits inside a<th colspan="5">rather than a<td>.This patch scopes the fix to notice list items only, avoiding unintended side effects on other lists within widefat tables
Trac ticket: https://core.trac.wordpress.org/ticket/53611
Use of AI Tools
AI assistance: Used for PR description
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.