Skip to content

#53611: Fix font size inconsistency in erasure notice list items - #12021

Closed
masteradhoc wants to merge 3 commits into
WordPress:trunkfrom
masteradhoc:53611-css-fix-privacy
Closed

#53611: Fix font size inconsistency in erasure notice list items#12021
masteradhoc wants to merge 3 commits into
WordPress:trunkfrom
masteradhoc:53611-css-fix-privacy

Conversation

@masteradhoc

@masteradhocmasteradhoc commented May 30, 2026

Copy link
Copy Markdown

Fix font size inconsistency in the data erasure inline notice for list items added via additionalMessages.

The inline notice rendered inside the personal data erasure list table contains a <p> element followed by a <ul> with plugin-provided messages. The <p> correctly inherits font-size: 13px from .notice p, but the <li> elements were inheriting font-size: 14px from the .widefat th rule, since the notice sits inside a <th colspan="5"> rather than a <td>.

This patch scopes the fix to notice list items only, avoiding unintended side effects on other lists within widefat tables

Trac ticket: https://core.trac.wordpress.org/ticket/53611

Use of AI Tools

AI assistance: Used for PR description


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actionsBot commented May 30, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props masteradhoc, joedolson.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment threadsrc/wp-admin/css/common.css Outdated
CopilotAI review requested due to automatic review settings July 24, 2026 21:09

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a typography inconsistency in the wp-admin “widefat” table inline notice used in personal data erasure requests, where list items inside a notice (rendered in a <th>) inherit the wrong font size.

Changes:

  • Adds a CSS rule to force .notice ul li inside .widefat table cells/headers to use the intended smaller font size.
  • Adjusts list-item line-height and spacing within those scoped notice lists.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadsrc/wp-admin/css/common.css

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/wp-admin/css/common.css:530

  • This rule adds margin: 0 0.5em; to notice list items inside widefat tables, which changes layout/indentation beyond the font-size/line-height fix described in the PR. If the goal is only to normalize typography for inline notices, consider dropping the margin override to keep the change narrowly scoped.
	font-size: 13px;
line-height: 1.54;
margin: 0 0.5em;

src/wp-admin/css/common.css:529

  • The PR description indicates line-height: 1.5em for this selector, but the implementation uses line-height: 1.54 (matching the .notice p rule in this file). Please align the PR description (and/or Trac ticket notes) with the actual value to avoid confusion during review/landing.
	line-height: 1.54;

@joedolsonjoedolson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving; will switch the margins in commit.

Comment threadsrc/wp-admin/css/common.css
pento pushed a commit that referenced this pull request Jul 24, 2026
Additional messages can be inserted by plugins using the `wp_privacy_personal_data_erasers` filter, and are generated as list items (`li`) inside the notice markup. However, `li` was not targeted with notice-specific styling, and inherited the list item styles from the containing table. Add additional styles targeting list items inside notices in list tables to equalize font sizes and styling.
Developed in #12021
Props kimannwall, masteradhoc, joedolson.
Fixes #53611.
git-svn-id: https://develop.svn.wordpress.org/trunk@62847 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62847
GitHub commit: 749e622

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jul 24, 2026
Additional messages can be inserted by plugins using the `wp_privacy_personal_data_erasers` filter, and are generated as list items (`li`) inside the notice markup. However, `li` was not targeted with notice-specific styling, and inherited the list item styles from the containing table. Add additional styles targeting list items inside notices in list tables to equalize font sizes and styling.
Developed in WordPress/wordpress-develop#12021
Props kimannwall, masteradhoc, joedolson.
Fixes #53611.
Built from https://develop.svn.wordpress.org/trunk@62847
git-svn-id: http://core.svn.wordpress.org/trunk@62127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@masteradhoc
masteradhoc deleted the 53611-css-fix-privacy branch July 25, 2026 05:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@masteradhoc@joedolson