Backporting block supports [border, color, elements, spacing] from Gutenberg to WP 6.1 by ramonjd · Pull Request #3204 · WordPress/wordpress-develop

ramonjd · 2022-09-07T05:45:02Z

~~❗ BLOCKED by #3199~~Edit: #3199 has been merged.

Backporting border, color, elements, spacing block supports changes from Gutenberg to WP 6.1

Typography is taken care of over in #3203

See tracking issue: WordPress/gutenberg#43440

Trac ticket: https://core.trac.wordpress.org/ticket/56467

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

ockham · 2022-09-15T13:26:42Z

Rebased, now that #3199 has landed.

ockham · 2022-09-15T14:07:36Z

Unit tests are failing -- apparently because of extra whitespace in the "expected" string. Errors look like this:

1) Test_Block_Supports_Border::test_border_color_slug_with_numbers_is_kebab_cased_properly
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
Array &0 (
'class' => 'has-border-color has-red-border-color'
- 'style' => 'border-radius: 10px; border-style: dashed; border-width: 1px;'
+ 'style' => 'border-radius:10px;border-style:dashed;border-width:1px;'
)
/var/www/tests/phpunit/tests/block-supports/border.php:70
phpvfscomposer:///var/www/vendor/phpunit/phpunit/phpunit:97
/var/www/vendor/bin/phpunit:118

ockham · 2022-09-15T14:19:53Z

A similar issue seems to be present over at #3237 (comment)

ramonjd · 2022-09-18T22:04:34Z

I'll rebase and fix. Sorry, was out of action last week.

…ons. The Style Engine does not prettify by default.

ramonjd · 2022-09-19T01:35:32Z

Unit tests are failing -- apparently because of extra whitespace in the "expected" string. Errors look like this:

@ockham Good to go I think.

ockham · 2022-09-19T12:21:21Z

+	wp_style_engine_get_styles(
+ $link_block_styles,
+ array(
+ 'selector' => ".$class_name a",
+ 'context' => 'block-supports',
+ )
+	);


Don't we have to do something with the return value? 🤔

I tried a paragraph block with a link and the link color set to orange, and it really isn't reflected on the frontend:

Ah, looks like this needs #3273 in order for the relevant styling to be added!

Don't we have to do something with the return value? 🤔
Not here since the style engine will register styles in a store using the context as key. Gutenberg fetches stored styles at render time and prints them out.

ockham

LGTM. We might want to land #3273 first and rebase this PR (see #3204 (comment)).

costdev

Thanks for handling this PR @ramonjd Just one minor suggestion 🙂

better consistency for `since` mentions. Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

better consistency for `since` mentions.

Better consistency for `since` mentions

audrasjb · 2022-09-19T20:25:46Z

Committed in https://core.trac.wordpress.org/changeset/54211

ramonjd · 2022-09-19T22:02:01Z

Thanks for all the help, folks!

This was referenced Sep 7, 2022
Plugin: Backport PHP changes for WordPress 6.1 release WordPress/gutenberg#43440
Closed
Style engine: migrate functions, classes and tests #3199
Closed

ramonjd force-pushed the update/backport-border-color-elements-spacing-block-supports-6-1 branch from 1614ef8 to c20ddd2Compare September 9, 2022 11:32

glendaviesnz mentioned this pull request Sep 15, 2022
Backport spacing presets #3255
Closed

ockham force-pushed the update/backport-border-color-elements-spacing-block-supports-6-1 branch from c20ddd2 to 569db97Compare September 15, 2022 13:25

ockham mentioned this pull request Sep 15, 2022
Backport script loader: enqueue stored block supports styles (refresh) #3259
Closed

ramonjd added 2 commits September 19, 2022 10:43

Backporting block supports from Gutenberg to WP 6.1
ae4742d

Formatting
ec6ea9d

ramonjd force-pushed the update/backport-border-color-elements-spacing-block-supports-6-1 branch from 569db97 to ec6ea9dCompare September 19, 2022 00:43

Updating CSS test output strings in the tests to non-prettified versi…
9a01f76
…ons. The Style Engine does not prettify by default.

ramonjd force-pushed the update/backport-border-color-elements-spacing-block-supports-6-1 branch from 7b8a48c to 9a01f76Compare September 19, 2022 01:17

ockham reviewed Sep 19, 2022
View reviewed changes

ockham approved these changes Sep 19, 2022
View reviewed changes

audrasjb self-assigned this Sep 19, 2022

costdev requested changes Sep 19, 2022
View reviewed changes

Comment threadsrc/wp-includes/block-supports/border.php Outdated

audrasjband others added 7 commits September 19, 2022 20:58

Update src/wp-includes/block-supports/border.php
5646544
better consistency for `since` mentions. Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

Update border.php
d13204d
better consistency for `since` mentions.

Update colors.php
9f2682c
better consistency for `since` mentions.

Update colors.php
e7cafa8
better consistency for `since` mentions.

Update colors.php
20e5b59
Better consistency for `since` mentions

Update elements.php
fb597d3
Better consistency for `since` mentions

Update spacing.php
bf978d4
Better consistency for `since` mentions

audrasjb closed this Sep 19, 2022

ramonjd deleted the update/backport-border-color-elements-spacing-block-supports-6-1 branch September 27, 2022 03:28

Uh oh!

Conversation

ramonjd commented Sep 7, 2022• edited by ockham Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ockham commented Sep 15, 2022

Uh oh!

ockham commented Sep 15, 2022

Uh oh!

ockham commented Sep 15, 2022

Uh oh!

ramonjd commented Sep 18, 2022

Uh oh!

ramonjd commented Sep 19, 2022

Uh oh!

ockhamSep 19, 2022

Choose a reason for hiding this comment

Uh oh!

ockhamSep 19, 2022

Choose a reason for hiding this comment

Uh oh!

ockhamSep 19, 2022

Choose a reason for hiding this comment

Uh oh!

ramonjdSep 19, 2022

Choose a reason for hiding this comment

Uh oh!

ockham left a comment

Choose a reason for hiding this comment

Uh oh!

costdev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

audrasjb commented Sep 19, 2022

Uh oh!

ramonjd commented Sep 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ramonjd commented Sep 7, 2022•
edited by ockham
Loading