Backport: Gutenberg 4434

[scruffian]

This is an attempt at a backport of WordPress/gutenberg#44334

The main part of this change is adding a new CSS file and I'm not sure how to do this - I'm guessing this comes from the packages, rather than me adding it manually.

@ockham any insight would be appreciated.

[ockham]

This is an attempt at a backport of WordPress/gutenberg#44334

The main part of this change is adding a new CSS file and I'm not sure how to do this - I'm guessing this comes from the packages, rather than me adding it manually.

I think that's accurate; according to unpkg.com, the package currently contains files such as common.css or theme.css at root level, so I'd expect classic.css to show up there, too.

I'll be publishing a new round of npms for WP 6.1 Beta 2 later today, and since we've cherry-picked WordPress/gutenberg#44334 to be included with it, we can check unpkg later to see if the file ended up there.

The path you're using to then locate the file in Core after a sync and build also matches where I'm seeing those other CSS files locally.

(To recap, we'll need to wait for packages to be published and synced before we can land this PR 😊 )

[ockham]

Published @wordpress/block-library@7.14.3. It has classic.css: https://unpkg.com/browse/@wordpress/block-library@7.14.3/build-style/classic.css.

Here's the sync PR: #3342

[ockham]

I'll rebase so this will pick up classic.css, now that the sync PR has landed.

[ockham]

Thank you @scruffian!

Confirming that this enqueues classic.css both on the frontend and in the editor ✅

LGTM!

[dream-encode]

I think these should probably be moved to wp-includes/default-filters.php where all other core hooks live. Probably around https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/default-filters.php#L558

[dream-encode]

I'll handle this in the merge though.

[ockham]

Thank you @dream-encode!

[ockham]

Some more detail from WordPress/gutenberg#44334 paper trail:

WordPress/gutenberg#43981 has testing instructions:

Testing Instructions

1. Switch to a classic theme that doesn't specify its own button styles (I'm using Canape)
2. Check that button look broken in trunk
3. Check out this PR
4. Check that buttons now look correct:

The styling was apparently originally removed by WordPress/gutenberg#34180, which was merged into Gutenberg in June. This means that it likely made its way into Core with the first package sync for WP 6.1. Testing this now.

[ockham]

The styling was apparently originally removed by WordPress/gutenberg#34180, which was merged into Gutenberg in June. This means that it likely made its way into Core with the first package sync for WP 6.1. Testing this now.

Confirming:

Before 3b63a75	At 3b63a75

[dream-encode]

Merged into core in https://core.trac.wordpress.org/changeset/54358.