Uh oh!
There was an error while loading. Please reload this page.
Backport: Bug fixes in theme json with fluid typography and spacing presets - #3362
Backport: Bug fixes in theme json with fluid typography and spacing presets#3362glendaviesnz wants to merge 2 commits into
Conversation
ramonjd
commented
Sep 29, 2022
Thanks @glendaviesnz This was an oversight on my part in the main Typgraphy PR that got merged #3237 |
ramonjd
commented
Sep 29, 2022
Thank you @glendaviesnz 💟 It's looking good. Should the spacing slug value be a string? E.g., 2023 theme.json"typography": {
"dropCap": false,
"fluid": true,
"fontFamilies": [
..."spacing": {
"spacingScale": {
"steps": 0
},
"spacingSizes": [
{
"size": "clamp(1.5rem, 5vw, 2rem)",
"slug": "30",
"name": "30"
},Export before"typography": {
"dropCap": false,
"fontFamilies": [
...."spacing": {
"spacingScale": [],
"spacingSizes": [
{
"name": "30",
"size": "clamp(1.5rem, 5vw, 2rem)",
"slug": 30
},After"typography": {
"dropCap": false,
"fluid": true,
"fontFamilies": [
..."spacing": {
"spacingScale": {
"steps": 0
},
"spacingSizes": [
{
"name": "30",
"size": "clamp(1.5rem, 5vw, 2rem)",
"slug": 30
},
|
ramonjd
left a comment
There was a problem hiding this comment.
Approving since the spacing slug number will be cast to a string when imported/injested.
The other two changes affect functionality and should be fixed.
dream-encode
commented
Sep 29, 2022
I was looking to merge this, but I want to make sure this comment by @tellthemachines is addressed in the final PR: |
dream-encode
commented
Sep 29, 2022
After looking at the code and the comments, it appears the concerns are addressed. Prepping a merge commit to core. |
dream-encode
commented
Sep 29, 2022
Merged into core in https://core.trac.wordpress.org/changeset/54360. |
The new fluid typography setting is missing from the theme.json valid values in 6.1, which causes the value to be dropped from theme exports from the editor as reported here.
Trac ticket: https://core.trac.wordpress.org/ticket/56684