Add caching to `get_adjacent_post`. by spacedmonkey · Pull Request #3366 · WordPress/wordpress-develop

spacedmonkey · 2022-09-29T10:57:56Z

Trac ticket: https://core.trac.wordpress.org/ticket/41131

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

peterwilsoncc

Is it possible to use WP_Query if the filters become wrappers for their Query equivalents? It might require closures but has the advantage of using the low level cache rather than a duplicate cache.

peterwilsoncc

Added a couple of notes/questions in case WP_Query is not a viable approach.

Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>

Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>

spacedmonkey · 2022-12-09T00:24:21Z

Is it possible to use WP_Query if the filters become wrappers for their Query equivalents? It might require closures but has the advantage of using the low level cache rather than a duplicate cache.

I thought that using WP_Query would be impossible. But I worked something out. #3734.

peterwilsoncc

This looks good but I've added a few notes inline.

Sorry about the bum steer suggesting WP_Query, I appreciate you giving it a go.

I merged in trunk to avoid the false failure due to the HTTP test that was failing until recently.

…3366

Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>

dd32

This looks good to me, I'd like to see this move forward :)

mukeshpanchal27 · 2023-01-18T06:56:55Z

+ $this->assertEquals( $post_one, $first_run, 'Get first post when on second post' );
+ $this->assertNotEquals( $post_two, $first_run, 'Do not get second post when on second post' );


Thanks for adding $message as per #3366 (comment) feedback. The $message parameter should explain what went wrong in the test. This message will be displayed when the assertion fails and can help immensely when debugging a test.

Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>

spacedmonkey · 2023-01-18T10:22:13Z

@mukeshpanchal27 Update messages. Your approval, I will commit this change.

mukeshpanchal27

Thanks @spacedmonkey, Amazing work! I think this is going to work out well!

spacedmonkey · 2023-01-18T11:20:31Z

Committed in 4108894

Add caching to get_adjacent_post.
a8c199c

spacedmonkey self-assigned this Sep 29, 2022

spacedmonkey requested review from adamsilverstein, felixarntz and peterwilsoncc December 7, 2022 16:51

mukeshpanchal27 reviewed Dec 7, 2022
View reviewed changes

Comment threadtests/phpunit/tests/link/getAdjacentPost.php Outdated

peterwilsoncc reviewed Dec 7, 2022
View reviewed changes

Comment threadtests/phpunit/tests/link/getAdjacentPost.php Outdated
Comment threadsrc/wp-includes/link-template.php Outdated

spacedmonkeyand others added 2 commits December 8, 2022 14:59

Apply suggestions from code review
8df0a78
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>

Apply suggestions from code review
a4b31c0
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>

spacedmonkey requested a review from dd32 December 14, 2022 10:52

This was referenced Dec 14, 2022
Add caching to get_adjacent_post - try 2. #3734
Closed
Add caching to get_adjacent_post - try 3. #3743
Closed

Merge branch 'trunk' into ticket/41131
78aeb1c

peterwilsoncc reviewed Dec 16, 2022
View reviewed changes

Comment threadtests/phpunit/tests/link/getAdjacentPost.php
Comment threadtests/phpunit/tests/link/getAdjacentPost.php Outdated
Comment threadtests/phpunit/tests/link/getAdjacentPost.php Outdated
Comment threadtests/phpunit/tests/link/getAdjacentPost.php Outdated

peterwilsoncc mentioned this pull request Dec 16, 2022
Move the counts cache uses to a persistent-counts group, using last_changed #3748
Open

dd32 added a commit to dd32/wordpress-develop that referenced this pull request Dec 19, 2022
Revert changes to get_adjacent_post() in preference for PRWordPress#…
a2404f9
…3366

spacedmonkey commented Jan 3, 2023
View reviewed changes

Comment threadtests/phpunit/tests/link/getAdjacentPost.php Outdated

spacedmonkey commented Jan 3, 2023
View reviewed changes

Comment threadtests/phpunit/tests/link/getAdjacentPost.php Outdated

spacedmonkeyand others added 5 commits January 3, 2023 15:47

Apply suggestions from code review
1157221
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>

Merge branch 'trunk' into ticket/41131
94efaab

Improve tests.
e2cc137

Fix lints
2366f75

Merge branch 'trunk' into ticket/41131
94a7520

spacedmonkey requested review from mukeshpanchal27 and peterwilsoncc and removed request for mukeshpanchal27 January 17, 2023 13:50

dd32 approved these changes Jan 18, 2023
View reviewed changes

mukeshpanchal27 reviewed Jan 18, 2023
View reviewed changes

Comment threadtests/phpunit/tests/link/getAdjacentPost.php Outdated

mukeshpanchal27 reviewed Jan 18, 2023
View reviewed changes

spacedmonkey added 2 commits January 18, 2023 10:10

Merge branch 'trunk' into ticket/41131
23a7364

Improve message in unit tests.
dce5189

spacedmonkey requested a review from mukeshpanchal27 January 18, 2023 10:18

Apply suggestions from code review
b5945b3
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>

mukeshpanchal27 approved these changes Jan 18, 2023
View reviewed changes

spacedmonkey closed this Jan 18, 2023

		$this->assertEquals( $post_one, $first_run, 'Get first post when on second post' );
		$this->assertNotEquals( $post_two, $first_run, 'Do not get second post when on second post' );

Uh oh!

Conversation

spacedmonkey commented Sep 29, 2022

Uh oh!

Uh oh!

peterwilsoncc left a comment

Choose a reason for hiding this comment

Uh oh!

peterwilsoncc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

spacedmonkey commented Dec 9, 2022

Uh oh!

peterwilsoncc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dd32 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mukeshpanchal27Jan 18, 2023

Choose a reason for hiding this comment

Uh oh!

spacedmonkey commented Jan 18, 2023

Uh oh!

mukeshpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

spacedmonkey commented Jan 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants