Uh oh!
There was an error while loading. Please reload this page.
Refresh: Upgrade to Requests 2.0.0 - #3732
Closed
costdev wants to merge 22 commits into
Closed
Conversation
costdev
marked this pull request as ready for review
December 7, 2022 17:58
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
costdevforce-pushed
the
upgrade-to-requests-2.0
branch
from
December 10, 2022 02:55
b5d5443 to
f4468f0Compare
Props hellofromtonya Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Props hellofromtonya Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Props hellofromtonya Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
costdevforce-pushed
the
upgrade-to-requests-2.0
branch
from
December 10, 2022 14:57
f4468f0 to
c6a4e10CompareUh oh!
There was an error while loading. Please reload this page.
hellofromtonya
approved these changes
Dec 15, 2022
hellofromtonya
left a comment
Contributor
There was a problem hiding this comment.
My testing also confirms it works as expected. It resolves the blocking issues of filesystem case-insensitivity and fatal errors from the intermixing of Requests 1.x with 2.x.
This PR is ready for commit ✅
hellofromtonya
commented
Dec 15, 2022
Contributor
Commit via changeset https://core.trac.wordpress.org/changeset/54997. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External libraries: upgrade to Requests 2.0.0
Upgrade references to the Requests library in the WP code
This PR:
src/wp-includes/Requests/src/.requirestatement forAutoload.phpinsrc/wp-includes/class-wp-http.php.$_old_files._preload_old_requests_files()to preload Requests 1.x slated for deletion._preload_old_requests_files()at the beginning ofupdate_core().Trac ticket: https://core.trac.wordpress.org/ticket/54504
Refresh of #1624.
How to Test?
Testing instructions are found here https://gist.github.com/hellofromtonya/bb0aa2d4b2311c8b40fa5ae8ada4dc19.