Uh oh!
There was an error while loading. Please reload this page.
Implemented documentation for privacy-tools.js - #6690
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
The docblock indention is not aligned.
narenin
commented
Jun 3, 2024
@mukeshpanchal27 I have implemented suggestions please check. |
narenin
commented
Jun 13, 2024
@mukeshpanchal27 Please let me know if any other changes needs to be made. |
| } | ||
| /** | ||
| * Set the export progress percentage. |
There was a problem hiding this comment.
Suggestion to make it clear: Updates the export progress indicator based on the current exporter index.
| /** | ||
| * Set the export progress percentage. | ||
| * | ||
| * @param {number} exporterIndex - The current exporter index. |
There was a problem hiding this comment.
Suggestion to clarify the parameter: The index of the current exporter being processed. Should be between 0 and exportersCount.
masteradhoc
commented
Jul 8, 2026
Hey @narenin Thanks for adding these JSDoc blocks — nice to see this function set documented! A few things to fix before this is ready per the [JS inline documentation standards]: 1. Missing 2. Drop the dash in @param{object}$action-jQueryobjectrepresentingtheactionelement.should be: @param{object}$actionjQueryobjectrepresentingtheactionelement.3. Align multi-param blocks * @param{object}$requestRow-jQueryobjectrepresentingtherequestrow.* @param{string}classes-CSSclassestoaddtotheresultsrow.* @param{string}summaryMessage-Summarymessagetodisplay.* @param{array}additionalMessages-Additionalmessagestodisplay.(this also applies to 4. Type casing 5. Following up on @VladimirAus's comments Happy to take another pass once these are in! |
Trac ticket: https://core.trac.wordpress.org/ticket/49381
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.