Skip to content

Site editor: preload post and template lookups if needed - #7695

Closed
ellatrix wants to merge 4 commits into
WordPress:trunkfrom
ellatrix:add/site-editor-preload-post
Closed

Site editor: preload post and template lookups if needed#7695
ellatrix wants to merge 4 commits into
WordPress:trunkfrom
ellatrix:add/site-editor-preload-post

Conversation

@ellatrix

@ellatrixellatrix commented Oct 31, 2024

Copy link
Copy Markdown
Member

@github-actions

github-actionsBot commented Oct 31, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ellatrix, swissspidy, mamaduka, jorgefilipecosta, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment threadsrc/wp-admin/site-editor.php Outdated
);

if ( ! empty( $_GET['postId'] ) ) {
$preload_paths[] = add_query_arg( 'context', 'edit', rest_get_route_for_post( $_GET['postId'] ) );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lacking any sort of sanitization.

Also rest_get_route_for_post can return an empty string if no post is found, in which case one wouldn't want do add this to the array.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the empty string check has already been added in GB.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed. Is get_post enough sanitisation?

@ellatrixellatrix changed the title Site editor: preload post if neededSite editor: preload post and template lookups if neededNov 1, 2024
$block_editor_context = new WP_Block_Editor_Context( array( 'name' => 'core/edit-site' ) );
$context_settings = array( 'name' => 'core/edit-site' );

if ( ! empty( $_GET['postId'] ) ) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's verify that postId is an int value.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ellatrix
ellatrixforce-pushed the add/site-editor-preload-post branch from b3481f1 to fb43af1CompareNovember 1, 2024 11:36

@jorgefilipecostajorgefilipecosta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my tests and the code looks good 👍

@peterwilsoncc

Copy link
Copy Markdown
Contributor

@ellatrix@youknowriad@Mamaduka Am I correct in assuming that this isn't affected by the switch to path based routing introduced in WordPress/gutenberg#67199?

(I'm pretty sure it isn't but want to avoid making assumptions :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ellatrix@peterwilsoncc@Mamaduka@swissspidy@jorgefilipecosta