Uh oh!
There was an error while loading. Please reload this page.
51928: Provides telemetry for plugin/theme update failures - #850
Open
hellofromtonya wants to merge 31 commits into
Open
51928: Provides telemetry for plugin/theme update failures#850hellofromtonya wants to merge 31 commits into
hellofromtonya wants to merge 31 commits into
Conversation
hellofromtonyaforce-pushed
the
add/51928-update-failure-telemetry
branch
from
January 3, 2021 18:57
d0cff26 to
7a23a89Comparehellofromtonyaforce-pushed
the
add/51928-update-failure-telemetry
branch
from
January 5, 2021 18:47
546cc80 to
ce8d1d6Comparehellofromtonya
marked this pull request as ready for review
January 5, 2021 20:30
…), ::upgrade(), and ::bulk_upgrade() methods only. Parent Theme installs gets special treatment, as it's a nested theme installer. The context (slug, version of package) is passed either directly, or by collecting it from the upgrader skin via the `api` property. Some newer code required adding some extra contextual arguements to the upgrader skin in order for ^ to work. By removing most of the calls from WP_Upgrader, it reduces the number of failure pings to once per process, rather than 2-3 as previously.
Props afragen See #2 (review)
Update 51928 update failure telemetry with simplified error handling
afragen
commented
Apr 15, 2022
Member
Merge conflicts should be fixed in hellofromtonya#4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/51928
time()tomicrotime( true )Notes:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.