[BREAKING FIX] [torchvision 0.17] Change functional_tensor import

[TornjV]

Fix for #649

[akx]

This would not be a breaking change if you try both imports:

Suggested change

	fromtorchvision.transforms.functionalimportrgb_to_grayscale
	try:
	fromtorchvision.transforms.functionalimportrgb_to_grayscale
	exceptImportError:
	fromtorchvision.transforms.functional_tensorimportrgb_to_grayscale

[Nitin13-git]

this will work--
try:
from torchvision.transforms.functional import rgb_to_grayscale
except ImportError:
from torchvision.transforms.functional_tensor import rgb_to_grayscale

[psychedelicious]

torchvision 0.17 was just released: https://github.com/pytorch/vision/releases/tag/v0.17.0

[yemreck]

can we merge it? 2 months since 0.17 released.

[psychedelicious]

Over at Invoke, we only use the RealESRGAN functionality provided by basicsr.

I extracted the relevant classes and cleaned them up a bit:

• basicsr
• RealESRGAN
• implementation

Maybe this is useful for others who only use this library for upscaling and would like to keep their other dependencies up to date.

[akx]

Over at Invoke, we only use the RealESRGAN functionality provided by basicsr.

The Spandrel project by the chaiNNer folks (disclaimer: I'm a contributor, and I also wired Spandrel up into a1111 in AUTOMATIC1111/stable-diffusion-webui#14425) implements RealESRGAN and various other upscaling and enhancement models in a clean way.

[psychedelicious]

Thanks for the link @akx ! This looks like a very ergonomic API, great work. Much nicer than what the basicsr repo provides (and my extracted version of it).

[yulin-li]

could we release a new version with this fix?

[blucz]

This bug continues to cause many users of downstream packages to manually hack up the basicsr code to get things to run, despite being fixed inmaster for nearly six months.

Is it possible for whoever controls the PyPI packaging to push the build button and release a new version?

[n0kovo]

@xinntao

[aminakmim]

Why this change is not appearing in PyPI package ?

[14790897]

warning: pypi package is not successfully pubilished

[14790897]

I released a fixed version to address this issue. Use pip install basicsr-fixed instead of pip install basicsr.