Chore/remove bundled workflow - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Pre-existing bundled CI workflow failing on every push
What broke: a workflow already present in the forked repo (Result Call Docker Build) tried to push to DockerHub and failed on a login step, since no DockerHub credentials existed in the fork.
Why: it came bundled with the original sample app's own repo — not something I created — and the guide explicitly says not to reuse the app repo's own pipeline.
Fix: removed the file entirely, since my own container build/push pipeline (Stages 7–8, using Trivy + ECR) replaces its function properly.