Try to minimize the scope of sudo use in scripts that require it - #82

Merged
solsson merged 3 commits into
mainfrom
sudo-minimal-scope
Aug 31, 2026
Merged

Try to minimize the scope of sudo use in scripts that require it#82
solsson merged 3 commits into
mainfrom
sudo-minimal-scope

Conversation

@solsson

@solssonsolsson commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

y-kubefwd and y-k8s-ingress-hosts do need the sudo, but should do as little as possible as sudo, in particular avoid kubectl because it might authenticate as the user.

Note that this means that kubefwd to GKE has only a 1hr lifetime. I think that's a feature.

solssonand others added 3 commits August 31, 2026 07:36
The script ran the whole k8s-ingress-hosts binary under sudo, so every
/etc/hosts update read the cluster as root: root ran gke-gcloud-auth-plugin,
which ran gcloud, which left root-owned files in the invoking user's
~/.config/gcloud and ~/.kube.
The binary has a -host-file flag, so the merge can happen on a copy as the
invoking user and only the resulting file needs privilege. The new
y-etc-hosts-write takes no arguments, refuses input that is empty or has no
127.0.0.1 entry, and swaps the file in with rename(2) so a reader never sees a
half-written /etc/hosts.
That also closes an escalation. The NOPASSWD rule granted
$YBIN/y-k8s-ingress-hosts-v*-bin *
and -host-file turns those wildcards into a write-any-file-as-root grant, e.g.
-host-file /etc/sudoers.d/x -write.
Also fixes a pre-existing set -e abort: grep -c prints 0 but exits 1 when no
GatewayClass carries yolean.se/dns-hint-ip, which killed the script before it
could fall back to the legacy annotation.
No flag or exit code changes. Help migrated to the YHELP/help-subcommand
convention. Verified against a stub binary: -check reports drift and exits 1,
--ensure writes and is then idempotent, a no-flag run still previews entries,
and Y_ETC_HOSTS makes the whole path testable without root.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kubefwd itself cannot avoid root. Upstream 1.25.16 says so in its own help
text -- "kubefwd needs sudo for /etc/hosts and network interfaces" -- and its
only no-sudo path is the mcp subcommand talking to an already-escalated
instance over the REST API. But sudo -E handed root the entire environment:
KUBECONFIG, HOME and PATH. Root therefore ran gke-gcloud-auth-plugin and
gcloud, which is what put root-owned files under the user's ~/.kube and
~/.config/gcloud, and made every token refresh a root-run gcloud.
Now the script generates a kubeconfig minified to the context and rewrites its
exec credential to drop back to the invoking user (sudo -u USER -H), so the
forwarder is the only thing running as root and all it ever receives is a
bearer token. Contexts without an exec block (client certs, local clusters)
pass through untouched. Preflight runs as the user so an expired login is
reported in your own session instead of from inside the root process.
The env hop in those exec args is load-bearing: sudo resets PATH to
secure_path, where the plugin fails with
exec: "gcloud": executable file not found in $PATH
so PATH is restored to the plugin's own directory, where gcloud is a sibling.
1.25.12 -> 1.25.16 also brings idle mode: with no -n/-A kubefwd now starts its
REST API and waits instead of forwarding, which the script now says out loud
rather than looking hung. Running the script itself as root is refused, and
the already-running guard exits 10 with pgrep -l (BSD pgrep has no -a).
Verified with a stub sudo: argument assembly, the generated credential, that
the rewritten exec command really returns an ExecCredential, and that 1.25.16
accepts our flags ahead of the svc subcommand.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The previous commit kept the exec plugin in the kubeconfig and only moved it
back to the invoking user with sudo -u. Root still drove it, and kubefwd
re-invokes the credential every minute or two (552 config-helper calls on
2026-08-11, 1071 on 08-12), so every one of those became a sudo as well. It
also left a gcloud-shaped hop in a script that has no business knowing about
gcloud.
Resolve the credential here instead, once, as the invoking user, and give
kubefwd a kubeconfig holding only the token that came back. This is the
client-go exec protocol, so nothing about it is gcloud specific: args, env and
KUBERNETES_EXEC_INFO all come from the context's own exec block, whatever
plugin it names. Contexts without one, client certificates on local clusters or
a static token, pass through untouched, and that is also where the long
sessions happen.
The trade is now stated instead of implicit: a GKE token lasts an hour and is
not renewed for a running kubefwd, so its expiry is printed at startup.
Two details worth keeping:
- The exec block has to be dropped, not just overwritten with a token. kubectl
keeps both and exec wins. Done with a fresh user entry plus a re-minify,
because unsetting users.NAME.exec needs a dotted path that breaks on user
names containing dots.
- Plugin stderr is captured separately. Folding it into stdout corrupts the
ExecCredential of any plugin that warns while succeeding, which a stub
reproduced.
Verified with stub plugins: the token path, a failing plugin, a plugin
answering with client certificates, that KUBERNETES_EXEC_INFO arrives
well-formed, and that a client-certificate context reaches kubefwd unchanged.
No cluster was contacted.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@solsson
solsson merged commit 4e5fd75 into mainAug 31, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@solsson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Try to minimize the scope of sudo use in scripts that require it - #82

Merged
solsson merged 3 commits into
mainfrom
sudo-minimal-scope
Aug 31, 2026
Merged

Try to minimize the scope of sudo use in scripts that require it#82
solsson merged 3 commits into
mainfrom
sudo-minimal-scope

Conversation

@solsson

@solssonsolsson commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

y-kubefwd and y-k8s-ingress-hosts do need the sudo, but should do as little as possible as sudo, in particular avoid kubectl because it might authenticate as the user.

Note that this means that kubefwd to GKE has only a 1hr lifetime. I think that's a feature.

solssonand others added 3 commits August 31, 2026 07:36
The script ran the whole k8s-ingress-hosts binary under sudo, so every
/etc/hosts update read the cluster as root: root ran gke-gcloud-auth-plugin,
which ran gcloud, which left root-owned files in the invoking user's
~/.config/gcloud and ~/.kube.
The binary has a -host-file flag, so the merge can happen on a copy as the
invoking user and only the resulting file needs privilege. The new
y-etc-hosts-write takes no arguments, refuses input that is empty or has no
127.0.0.1 entry, and swaps the file in with rename(2) so a reader never sees a
half-written /etc/hosts.
That also closes an escalation. The NOPASSWD rule granted
$YBIN/y-k8s-ingress-hosts-v*-bin *
and -host-file turns those wildcards into a write-any-file-as-root grant, e.g.
-host-file /etc/sudoers.d/x -write.
Also fixes a pre-existing set -e abort: grep -c prints 0 but exits 1 when no
GatewayClass carries yolean.se/dns-hint-ip, which killed the script before it
could fall back to the legacy annotation.
No flag or exit code changes. Help migrated to the YHELP/help-subcommand
convention. Verified against a stub binary: -check reports drift and exits 1,
--ensure writes and is then idempotent, a no-flag run still previews entries,
and Y_ETC_HOSTS makes the whole path testable without root.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kubefwd itself cannot avoid root. Upstream 1.25.16 says so in its own help
text -- "kubefwd needs sudo for /etc/hosts and network interfaces" -- and its
only no-sudo path is the mcp subcommand talking to an already-escalated
instance over the REST API. But sudo -E handed root the entire environment:
KUBECONFIG, HOME and PATH. Root therefore ran gke-gcloud-auth-plugin and
gcloud, which is what put root-owned files under the user's ~/.kube and
~/.config/gcloud, and made every token refresh a root-run gcloud.
Now the script generates a kubeconfig minified to the context and rewrites its
exec credential to drop back to the invoking user (sudo -u USER -H), so the
forwarder is the only thing running as root and all it ever receives is a
bearer token. Contexts without an exec block (client certs, local clusters)
pass through untouched. Preflight runs as the user so an expired login is
reported in your own session instead of from inside the root process.
The env hop in those exec args is load-bearing: sudo resets PATH to
secure_path, where the plugin fails with
exec: "gcloud": executable file not found in $PATH
so PATH is restored to the plugin's own directory, where gcloud is a sibling.
1.25.12 -> 1.25.16 also brings idle mode: with no -n/-A kubefwd now starts its
REST API and waits instead of forwarding, which the script now says out loud
rather than looking hung. Running the script itself as root is refused, and
the already-running guard exits 10 with pgrep -l (BSD pgrep has no -a).
Verified with a stub sudo: argument assembly, the generated credential, that
the rewritten exec command really returns an ExecCredential, and that 1.25.16
accepts our flags ahead of the svc subcommand.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The previous commit kept the exec plugin in the kubeconfig and only moved it
back to the invoking user with sudo -u. Root still drove it, and kubefwd
re-invokes the credential every minute or two (552 config-helper calls on
2026-08-11, 1071 on 08-12), so every one of those became a sudo as well. It
also left a gcloud-shaped hop in a script that has no business knowing about
gcloud.
Resolve the credential here instead, once, as the invoking user, and give
kubefwd a kubeconfig holding only the token that came back. This is the
client-go exec protocol, so nothing about it is gcloud specific: args, env and
KUBERNETES_EXEC_INFO all come from the context's own exec block, whatever
plugin it names. Contexts without one, client certificates on local clusters or
a static token, pass through untouched, and that is also where the long
sessions happen.
The trade is now stated instead of implicit: a GKE token lasts an hour and is
not renewed for a running kubefwd, so its expiry is printed at startup.
Two details worth keeping:
- The exec block has to be dropped, not just overwritten with a token. kubectl
keeps both and exec wins. Done with a fresh user entry plus a re-minify,
because unsetting users.NAME.exec needs a dotted path that breaks on user
names containing dots.
- Plugin stderr is captured separately. Folding it into stdout corrupts the
ExecCredential of any plugin that warns while succeeding, which a stub
reproduced.
Verified with stub plugins: the token path, a failing plugin, a plugin
answering with client certificates, that KUBERNETES_EXEC_INFO arrives
well-formed, and that a client-certificate context reaches kubefwd unchanged.
No cluster was contacted.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@solsson
solsson merged commit 4e5fd75 into mainAug 31, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@solsson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Try to minimize the scope of sudo use in scripts that require it - #82

Merged
solsson merged 3 commits into
mainfrom
sudo-minimal-scope
Aug 31, 2026
Merged

Try to minimize the scope of sudo use in scripts that require it#82
solsson merged 3 commits into
mainfrom
sudo-minimal-scope

Conversation

@solsson

@solssonsolsson commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

y-kubefwd and y-k8s-ingress-hosts do need the sudo, but should do as little as possible as sudo, in particular avoid kubectl because it might authenticate as the user.

Note that this means that kubefwd to GKE has only a 1hr lifetime. I think that's a feature.

solssonand others added 3 commits August 31, 2026 07:36
The script ran the whole k8s-ingress-hosts binary under sudo, so every
/etc/hosts update read the cluster as root: root ran gke-gcloud-auth-plugin,
which ran gcloud, which left root-owned files in the invoking user's
~/.config/gcloud and ~/.kube.
The binary has a -host-file flag, so the merge can happen on a copy as the
invoking user and only the resulting file needs privilege. The new
y-etc-hosts-write takes no arguments, refuses input that is empty or has no
127.0.0.1 entry, and swaps the file in with rename(2) so a reader never sees a
half-written /etc/hosts.
That also closes an escalation. The NOPASSWD rule granted
$YBIN/y-k8s-ingress-hosts-v*-bin *
and -host-file turns those wildcards into a write-any-file-as-root grant, e.g.
-host-file /etc/sudoers.d/x -write.
Also fixes a pre-existing set -e abort: grep -c prints 0 but exits 1 when no
GatewayClass carries yolean.se/dns-hint-ip, which killed the script before it
could fall back to the legacy annotation.
No flag or exit code changes. Help migrated to the YHELP/help-subcommand
convention. Verified against a stub binary: -check reports drift and exits 1,
--ensure writes and is then idempotent, a no-flag run still previews entries,
and Y_ETC_HOSTS makes the whole path testable without root.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kubefwd itself cannot avoid root. Upstream 1.25.16 says so in its own help
text -- "kubefwd needs sudo for /etc/hosts and network interfaces" -- and its
only no-sudo path is the mcp subcommand talking to an already-escalated
instance over the REST API. But sudo -E handed root the entire environment:
KUBECONFIG, HOME and PATH. Root therefore ran gke-gcloud-auth-plugin and
gcloud, which is what put root-owned files under the user's ~/.kube and
~/.config/gcloud, and made every token refresh a root-run gcloud.
Now the script generates a kubeconfig minified to the context and rewrites its
exec credential to drop back to the invoking user (sudo -u USER -H), so the
forwarder is the only thing running as root and all it ever receives is a
bearer token. Contexts without an exec block (client certs, local clusters)
pass through untouched. Preflight runs as the user so an expired login is
reported in your own session instead of from inside the root process.
The env hop in those exec args is load-bearing: sudo resets PATH to
secure_path, where the plugin fails with
exec: "gcloud": executable file not found in $PATH
so PATH is restored to the plugin's own directory, where gcloud is a sibling.
1.25.12 -> 1.25.16 also brings idle mode: with no -n/-A kubefwd now starts its
REST API and waits instead of forwarding, which the script now says out loud
rather than looking hung. Running the script itself as root is refused, and
the already-running guard exits 10 with pgrep -l (BSD pgrep has no -a).
Verified with a stub sudo: argument assembly, the generated credential, that
the rewritten exec command really returns an ExecCredential, and that 1.25.16
accepts our flags ahead of the svc subcommand.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The previous commit kept the exec plugin in the kubeconfig and only moved it
back to the invoking user with sudo -u. Root still drove it, and kubefwd
re-invokes the credential every minute or two (552 config-helper calls on
2026-08-11, 1071 on 08-12), so every one of those became a sudo as well. It
also left a gcloud-shaped hop in a script that has no business knowing about
gcloud.
Resolve the credential here instead, once, as the invoking user, and give
kubefwd a kubeconfig holding only the token that came back. This is the
client-go exec protocol, so nothing about it is gcloud specific: args, env and
KUBERNETES_EXEC_INFO all come from the context's own exec block, whatever
plugin it names. Contexts without one, client certificates on local clusters or
a static token, pass through untouched, and that is also where the long
sessions happen.
The trade is now stated instead of implicit: a GKE token lasts an hour and is
not renewed for a running kubefwd, so its expiry is printed at startup.
Two details worth keeping:
- The exec block has to be dropped, not just overwritten with a token. kubectl
keeps both and exec wins. Done with a fresh user entry plus a re-minify,
because unsetting users.NAME.exec needs a dotted path that breaks on user
names containing dots.
- Plugin stderr is captured separately. Folding it into stdout corrupts the
ExecCredential of any plugin that warns while succeeding, which a stub
reproduced.
Verified with stub plugins: the token path, a failing plugin, a plugin
answering with client certificates, that KUBERNETES_EXEC_INFO arrives
well-formed, and that a client-certificate context reaches kubefwd unchanged.
No cluster was contacted.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@solsson
solsson merged commit 4e5fd75 into mainAug 31, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@solsson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Try to minimize the scope of sudo use in scripts that require it - #82

Merged
solsson merged 3 commits into
mainfrom
sudo-minimal-scope
Aug 31, 2026
Merged

Try to minimize the scope of sudo use in scripts that require it#82
solsson merged 3 commits into
mainfrom
sudo-minimal-scope

Conversation

@solsson

@solssonsolsson commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

y-kubefwd and y-k8s-ingress-hosts do need the sudo, but should do as little as possible as sudo, in particular avoid kubectl because it might authenticate as the user.

Note that this means that kubefwd to GKE has only a 1hr lifetime. I think that's a feature.

solssonand others added 3 commits August 31, 2026 07:36
The script ran the whole k8s-ingress-hosts binary under sudo, so every
/etc/hosts update read the cluster as root: root ran gke-gcloud-auth-plugin,
which ran gcloud, which left root-owned files in the invoking user's
~/.config/gcloud and ~/.kube.
The binary has a -host-file flag, so the merge can happen on a copy as the
invoking user and only the resulting file needs privilege. The new
y-etc-hosts-write takes no arguments, refuses input that is empty or has no
127.0.0.1 entry, and swaps the file in with rename(2) so a reader never sees a
half-written /etc/hosts.
That also closes an escalation. The NOPASSWD rule granted
$YBIN/y-k8s-ingress-hosts-v*-bin *
and -host-file turns those wildcards into a write-any-file-as-root grant, e.g.
-host-file /etc/sudoers.d/x -write.
Also fixes a pre-existing set -e abort: grep -c prints 0 but exits 1 when no
GatewayClass carries yolean.se/dns-hint-ip, which killed the script before it
could fall back to the legacy annotation.
No flag or exit code changes. Help migrated to the YHELP/help-subcommand
convention. Verified against a stub binary: -check reports drift and exits 1,
--ensure writes and is then idempotent, a no-flag run still previews entries,
and Y_ETC_HOSTS makes the whole path testable without root.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kubefwd itself cannot avoid root. Upstream 1.25.16 says so in its own help
text -- "kubefwd needs sudo for /etc/hosts and network interfaces" -- and its
only no-sudo path is the mcp subcommand talking to an already-escalated
instance over the REST API. But sudo -E handed root the entire environment:
KUBECONFIG, HOME and PATH. Root therefore ran gke-gcloud-auth-plugin and
gcloud, which is what put root-owned files under the user's ~/.kube and
~/.config/gcloud, and made every token refresh a root-run gcloud.
Now the script generates a kubeconfig minified to the context and rewrites its
exec credential to drop back to the invoking user (sudo -u USER -H), so the
forwarder is the only thing running as root and all it ever receives is a
bearer token. Contexts without an exec block (client certs, local clusters)
pass through untouched. Preflight runs as the user so an expired login is
reported in your own session instead of from inside the root process.
The env hop in those exec args is load-bearing: sudo resets PATH to
secure_path, where the plugin fails with
exec: "gcloud": executable file not found in $PATH
so PATH is restored to the plugin's own directory, where gcloud is a sibling.
1.25.12 -> 1.25.16 also brings idle mode: with no -n/-A kubefwd now starts its
REST API and waits instead of forwarding, which the script now says out loud
rather than looking hung. Running the script itself as root is refused, and
the already-running guard exits 10 with pgrep -l (BSD pgrep has no -a).
Verified with a stub sudo: argument assembly, the generated credential, that
the rewritten exec command really returns an ExecCredential, and that 1.25.16
accepts our flags ahead of the svc subcommand.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The previous commit kept the exec plugin in the kubeconfig and only moved it
back to the invoking user with sudo -u. Root still drove it, and kubefwd
re-invokes the credential every minute or two (552 config-helper calls on
2026-08-11, 1071 on 08-12), so every one of those became a sudo as well. It
also left a gcloud-shaped hop in a script that has no business knowing about
gcloud.
Resolve the credential here instead, once, as the invoking user, and give
kubefwd a kubeconfig holding only the token that came back. This is the
client-go exec protocol, so nothing about it is gcloud specific: args, env and
KUBERNETES_EXEC_INFO all come from the context's own exec block, whatever
plugin it names. Contexts without one, client certificates on local clusters or
a static token, pass through untouched, and that is also where the long
sessions happen.
The trade is now stated instead of implicit: a GKE token lasts an hour and is
not renewed for a running kubefwd, so its expiry is printed at startup.
Two details worth keeping:
- The exec block has to be dropped, not just overwritten with a token. kubectl
keeps both and exec wins. Done with a fresh user entry plus a re-minify,
because unsetting users.NAME.exec needs a dotted path that breaks on user
names containing dots.
- Plugin stderr is captured separately. Folding it into stdout corrupts the
ExecCredential of any plugin that warns while succeeding, which a stub
reproduced.
Verified with stub plugins: the token path, a failing plugin, a plugin
answering with client certificates, that KUBERNETES_EXEC_INFO arrives
well-formed, and that a client-certificate context reaches kubefwd unchanged.
No cluster was contacted.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@solsson
solsson merged commit 4e5fd75 into mainAug 31, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@solsson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Try to minimize the scope of sudo use in scripts that require it - #82

Merged
solsson merged 3 commits into
mainfrom
sudo-minimal-scope
Aug 31, 2026
Merged

Try to minimize the scope of sudo use in scripts that require it#82
solsson merged 3 commits into
mainfrom
sudo-minimal-scope

Conversation

@solsson

@solssonsolsson commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

y-kubefwd and y-k8s-ingress-hosts do need the sudo, but should do as little as possible as sudo, in particular avoid kubectl because it might authenticate as the user.

Note that this means that kubefwd to GKE has only a 1hr lifetime. I think that's a feature.

solssonand others added 3 commits August 31, 2026 07:36
The script ran the whole k8s-ingress-hosts binary under sudo, so every
/etc/hosts update read the cluster as root: root ran gke-gcloud-auth-plugin,
which ran gcloud, which left root-owned files in the invoking user's
~/.config/gcloud and ~/.kube.
The binary has a -host-file flag, so the merge can happen on a copy as the
invoking user and only the resulting file needs privilege. The new
y-etc-hosts-write takes no arguments, refuses input that is empty or has no
127.0.0.1 entry, and swaps the file in with rename(2) so a reader never sees a
half-written /etc/hosts.
That also closes an escalation. The NOPASSWD rule granted
$YBIN/y-k8s-ingress-hosts-v*-bin *
and -host-file turns those wildcards into a write-any-file-as-root grant, e.g.
-host-file /etc/sudoers.d/x -write.
Also fixes a pre-existing set -e abort: grep -c prints 0 but exits 1 when no
GatewayClass carries yolean.se/dns-hint-ip, which killed the script before it
could fall back to the legacy annotation.
No flag or exit code changes. Help migrated to the YHELP/help-subcommand
convention. Verified against a stub binary: -check reports drift and exits 1,
--ensure writes and is then idempotent, a no-flag run still previews entries,
and Y_ETC_HOSTS makes the whole path testable without root.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kubefwd itself cannot avoid root. Upstream 1.25.16 says so in its own help
text -- "kubefwd needs sudo for /etc/hosts and network interfaces" -- and its
only no-sudo path is the mcp subcommand talking to an already-escalated
instance over the REST API. But sudo -E handed root the entire environment:
KUBECONFIG, HOME and PATH. Root therefore ran gke-gcloud-auth-plugin and
gcloud, which is what put root-owned files under the user's ~/.kube and
~/.config/gcloud, and made every token refresh a root-run gcloud.
Now the script generates a kubeconfig minified to the context and rewrites its
exec credential to drop back to the invoking user (sudo -u USER -H), so the
forwarder is the only thing running as root and all it ever receives is a
bearer token. Contexts without an exec block (client certs, local clusters)
pass through untouched. Preflight runs as the user so an expired login is
reported in your own session instead of from inside the root process.
The env hop in those exec args is load-bearing: sudo resets PATH to
secure_path, where the plugin fails with
exec: "gcloud": executable file not found in $PATH
so PATH is restored to the plugin's own directory, where gcloud is a sibling.
1.25.12 -> 1.25.16 also brings idle mode: with no -n/-A kubefwd now starts its
REST API and waits instead of forwarding, which the script now says out loud
rather than looking hung. Running the script itself as root is refused, and
the already-running guard exits 10 with pgrep -l (BSD pgrep has no -a).
Verified with a stub sudo: argument assembly, the generated credential, that
the rewritten exec command really returns an ExecCredential, and that 1.25.16
accepts our flags ahead of the svc subcommand.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The previous commit kept the exec plugin in the kubeconfig and only moved it
back to the invoking user with sudo -u. Root still drove it, and kubefwd
re-invokes the credential every minute or two (552 config-helper calls on
2026-08-11, 1071 on 08-12), so every one of those became a sudo as well. It
also left a gcloud-shaped hop in a script that has no business knowing about
gcloud.
Resolve the credential here instead, once, as the invoking user, and give
kubefwd a kubeconfig holding only the token that came back. This is the
client-go exec protocol, so nothing about it is gcloud specific: args, env and
KUBERNETES_EXEC_INFO all come from the context's own exec block, whatever
plugin it names. Contexts without one, client certificates on local clusters or
a static token, pass through untouched, and that is also where the long
sessions happen.
The trade is now stated instead of implicit: a GKE token lasts an hour and is
not renewed for a running kubefwd, so its expiry is printed at startup.
Two details worth keeping:
- The exec block has to be dropped, not just overwritten with a token. kubectl
keeps both and exec wins. Done with a fresh user entry plus a re-minify,
because unsetting users.NAME.exec needs a dotted path that breaks on user
names containing dots.
- Plugin stderr is captured separately. Folding it into stdout corrupts the
ExecCredential of any plugin that warns while succeeding, which a stub
reproduced.
Verified with stub plugins: the token path, a failing plugin, a plugin
answering with client certificates, that KUBERNETES_EXEC_INFO arrives
well-formed, and that a client-certificate context reaches kubefwd unchanged.
No cluster was contacted.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@solsson
solsson merged commit 4e5fd75 into mainAug 31, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@solsson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Try to minimize the scope of sudo use in scripts that require it - #82

Merged
solsson merged 3 commits into
mainfrom
sudo-minimal-scope
Aug 31, 2026
Merged

Try to minimize the scope of sudo use in scripts that require it#82
solsson merged 3 commits into
mainfrom
sudo-minimal-scope

Conversation

@solsson

@solssonsolsson commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

y-kubefwd and y-k8s-ingress-hosts do need the sudo, but should do as little as possible as sudo, in particular avoid kubectl because it might authenticate as the user.

Note that this means that kubefwd to GKE has only a 1hr lifetime. I think that's a feature.

solssonand others added 3 commits August 31, 2026 07:36
The script ran the whole k8s-ingress-hosts binary under sudo, so every
/etc/hosts update read the cluster as root: root ran gke-gcloud-auth-plugin,
which ran gcloud, which left root-owned files in the invoking user's
~/.config/gcloud and ~/.kube.
The binary has a -host-file flag, so the merge can happen on a copy as the
invoking user and only the resulting file needs privilege. The new
y-etc-hosts-write takes no arguments, refuses input that is empty or has no
127.0.0.1 entry, and swaps the file in with rename(2) so a reader never sees a
half-written /etc/hosts.
That also closes an escalation. The NOPASSWD rule granted
$YBIN/y-k8s-ingress-hosts-v*-bin *
and -host-file turns those wildcards into a write-any-file-as-root grant, e.g.
-host-file /etc/sudoers.d/x -write.
Also fixes a pre-existing set -e abort: grep -c prints 0 but exits 1 when no
GatewayClass carries yolean.se/dns-hint-ip, which killed the script before it
could fall back to the legacy annotation.
No flag or exit code changes. Help migrated to the YHELP/help-subcommand
convention. Verified against a stub binary: -check reports drift and exits 1,
--ensure writes and is then idempotent, a no-flag run still previews entries,
and Y_ETC_HOSTS makes the whole path testable without root.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kubefwd itself cannot avoid root. Upstream 1.25.16 says so in its own help
text -- "kubefwd needs sudo for /etc/hosts and network interfaces" -- and its
only no-sudo path is the mcp subcommand talking to an already-escalated
instance over the REST API. But sudo -E handed root the entire environment:
KUBECONFIG, HOME and PATH. Root therefore ran gke-gcloud-auth-plugin and
gcloud, which is what put root-owned files under the user's ~/.kube and
~/.config/gcloud, and made every token refresh a root-run gcloud.
Now the script generates a kubeconfig minified to the context and rewrites its
exec credential to drop back to the invoking user (sudo -u USER -H), so the
forwarder is the only thing running as root and all it ever receives is a
bearer token. Contexts without an exec block (client certs, local clusters)
pass through untouched. Preflight runs as the user so an expired login is
reported in your own session instead of from inside the root process.
The env hop in those exec args is load-bearing: sudo resets PATH to
secure_path, where the plugin fails with
exec: "gcloud": executable file not found in $PATH
so PATH is restored to the plugin's own directory, where gcloud is a sibling.
1.25.12 -> 1.25.16 also brings idle mode: with no -n/-A kubefwd now starts its
REST API and waits instead of forwarding, which the script now says out loud
rather than looking hung. Running the script itself as root is refused, and
the already-running guard exits 10 with pgrep -l (BSD pgrep has no -a).
Verified with a stub sudo: argument assembly, the generated credential, that
the rewritten exec command really returns an ExecCredential, and that 1.25.16
accepts our flags ahead of the svc subcommand.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The previous commit kept the exec plugin in the kubeconfig and only moved it
back to the invoking user with sudo -u. Root still drove it, and kubefwd
re-invokes the credential every minute or two (552 config-helper calls on
2026-08-11, 1071 on 08-12), so every one of those became a sudo as well. It
also left a gcloud-shaped hop in a script that has no business knowing about
gcloud.
Resolve the credential here instead, once, as the invoking user, and give
kubefwd a kubeconfig holding only the token that came back. This is the
client-go exec protocol, so nothing about it is gcloud specific: args, env and
KUBERNETES_EXEC_INFO all come from the context's own exec block, whatever
plugin it names. Contexts without one, client certificates on local clusters or
a static token, pass through untouched, and that is also where the long
sessions happen.
The trade is now stated instead of implicit: a GKE token lasts an hour and is
not renewed for a running kubefwd, so its expiry is printed at startup.
Two details worth keeping:
- The exec block has to be dropped, not just overwritten with a token. kubectl
keeps both and exec wins. Done with a fresh user entry plus a re-minify,
because unsetting users.NAME.exec needs a dotted path that breaks on user
names containing dots.
- Plugin stderr is captured separately. Folding it into stdout corrupts the
ExecCredential of any plugin that warns while succeeding, which a stub
reproduced.
Verified with stub plugins: the token path, a failing plugin, a plugin
answering with client certificates, that KUBERNETES_EXEC_INFO arrives
well-formed, and that a client-certificate context reaches kubefwd unchanged.
No cluster was contacted.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@solsson
solsson merged commit 4e5fd75 into mainAug 31, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@solsson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Try to minimize the scope of sudo use in scripts that require it - #82

Merged
solsson merged 3 commits into
mainfrom
sudo-minimal-scope
Aug 31, 2026
Merged

Try to minimize the scope of sudo use in scripts that require it#82
solsson merged 3 commits into
mainfrom
sudo-minimal-scope

Conversation

@solsson

@solssonsolsson commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

y-kubefwd and y-k8s-ingress-hosts do need the sudo, but should do as little as possible as sudo, in particular avoid kubectl because it might authenticate as the user.

Note that this means that kubefwd to GKE has only a 1hr lifetime. I think that's a feature.

solssonand others added 3 commits August 31, 2026 07:36
The script ran the whole k8s-ingress-hosts binary under sudo, so every
/etc/hosts update read the cluster as root: root ran gke-gcloud-auth-plugin,
which ran gcloud, which left root-owned files in the invoking user's
~/.config/gcloud and ~/.kube.
The binary has a -host-file flag, so the merge can happen on a copy as the
invoking user and only the resulting file needs privilege. The new
y-etc-hosts-write takes no arguments, refuses input that is empty or has no
127.0.0.1 entry, and swaps the file in with rename(2) so a reader never sees a
half-written /etc/hosts.
That also closes an escalation. The NOPASSWD rule granted
$YBIN/y-k8s-ingress-hosts-v*-bin *
and -host-file turns those wildcards into a write-any-file-as-root grant, e.g.
-host-file /etc/sudoers.d/x -write.
Also fixes a pre-existing set -e abort: grep -c prints 0 but exits 1 when no
GatewayClass carries yolean.se/dns-hint-ip, which killed the script before it
could fall back to the legacy annotation.
No flag or exit code changes. Help migrated to the YHELP/help-subcommand
convention. Verified against a stub binary: -check reports drift and exits 1,
--ensure writes and is then idempotent, a no-flag run still previews entries,
and Y_ETC_HOSTS makes the whole path testable without root.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kubefwd itself cannot avoid root. Upstream 1.25.16 says so in its own help
text -- "kubefwd needs sudo for /etc/hosts and network interfaces" -- and its
only no-sudo path is the mcp subcommand talking to an already-escalated
instance over the REST API. But sudo -E handed root the entire environment:
KUBECONFIG, HOME and PATH. Root therefore ran gke-gcloud-auth-plugin and
gcloud, which is what put root-owned files under the user's ~/.kube and
~/.config/gcloud, and made every token refresh a root-run gcloud.
Now the script generates a kubeconfig minified to the context and rewrites its
exec credential to drop back to the invoking user (sudo -u USER -H), so the
forwarder is the only thing running as root and all it ever receives is a
bearer token. Contexts without an exec block (client certs, local clusters)
pass through untouched. Preflight runs as the user so an expired login is
reported in your own session instead of from inside the root process.
The env hop in those exec args is load-bearing: sudo resets PATH to
secure_path, where the plugin fails with
exec: "gcloud": executable file not found in $PATH
so PATH is restored to the plugin's own directory, where gcloud is a sibling.
1.25.12 -> 1.25.16 also brings idle mode: with no -n/-A kubefwd now starts its
REST API and waits instead of forwarding, which the script now says out loud
rather than looking hung. Running the script itself as root is refused, and
the already-running guard exits 10 with pgrep -l (BSD pgrep has no -a).
Verified with a stub sudo: argument assembly, the generated credential, that
the rewritten exec command really returns an ExecCredential, and that 1.25.16
accepts our flags ahead of the svc subcommand.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The previous commit kept the exec plugin in the kubeconfig and only moved it
back to the invoking user with sudo -u. Root still drove it, and kubefwd
re-invokes the credential every minute or two (552 config-helper calls on
2026-08-11, 1071 on 08-12), so every one of those became a sudo as well. It
also left a gcloud-shaped hop in a script that has no business knowing about
gcloud.
Resolve the credential here instead, once, as the invoking user, and give
kubefwd a kubeconfig holding only the token that came back. This is the
client-go exec protocol, so nothing about it is gcloud specific: args, env and
KUBERNETES_EXEC_INFO all come from the context's own exec block, whatever
plugin it names. Contexts without one, client certificates on local clusters or
a static token, pass through untouched, and that is also where the long
sessions happen.
The trade is now stated instead of implicit: a GKE token lasts an hour and is
not renewed for a running kubefwd, so its expiry is printed at startup.
Two details worth keeping:
- The exec block has to be dropped, not just overwritten with a token. kubectl
keeps both and exec wins. Done with a fresh user entry plus a re-minify,
because unsetting users.NAME.exec needs a dotted path that breaks on user
names containing dots.
- Plugin stderr is captured separately. Folding it into stdout corrupts the
ExecCredential of any plugin that warns while succeeding, which a stub
reproduced.
Verified with stub plugins: the token path, a failing plugin, a plugin
answering with client certificates, that KUBERNETES_EXEC_INFO arrives
well-formed, and that a client-certificate context reaches kubefwd unchanged.
No cluster was contacted.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@solsson
solsson merged commit 4e5fd75 into mainAug 31, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@solsson
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Try to minimize the scope of sudo use in scripts that require it - #82

Merged
solsson merged 3 commits into
mainfrom
sudo-minimal-scope
Aug 31, 2026
Merged

Try to minimize the scope of sudo use in scripts that require it#82
solsson merged 3 commits into
mainfrom
sudo-minimal-scope

Conversation

@solsson

@solssonsolsson commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

y-kubefwd and y-k8s-ingress-hosts do need the sudo, but should do as little as possible as sudo, in particular avoid kubectl because it might authenticate as the user.

Note that this means that kubefwd to GKE has only a 1hr lifetime. I think that's a feature.

solssonand others added 3 commits August 31, 2026 07:36
The script ran the whole k8s-ingress-hosts binary under sudo, so every
/etc/hosts update read the cluster as root: root ran gke-gcloud-auth-plugin,
which ran gcloud, which left root-owned files in the invoking user's
~/.config/gcloud and ~/.kube.
The binary has a -host-file flag, so the merge can happen on a copy as the
invoking user and only the resulting file needs privilege. The new
y-etc-hosts-write takes no arguments, refuses input that is empty or has no
127.0.0.1 entry, and swaps the file in with rename(2) so a reader never sees a
half-written /etc/hosts.
That also closes an escalation. The NOPASSWD rule granted
$YBIN/y-k8s-ingress-hosts-v*-bin *
and -host-file turns those wildcards into a write-any-file-as-root grant, e.g.
-host-file /etc/sudoers.d/x -write.
Also fixes a pre-existing set -e abort: grep -c prints 0 but exits 1 when no
GatewayClass carries yolean.se/dns-hint-ip, which killed the script before it
could fall back to the legacy annotation.
No flag or exit code changes. Help migrated to the YHELP/help-subcommand
convention. Verified against a stub binary: -check reports drift and exits 1,
--ensure writes and is then idempotent, a no-flag run still previews entries,
and Y_ETC_HOSTS makes the whole path testable without root.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kubefwd itself cannot avoid root. Upstream 1.25.16 says so in its own help
text -- "kubefwd needs sudo for /etc/hosts and network interfaces" -- and its
only no-sudo path is the mcp subcommand talking to an already-escalated
instance over the REST API. But sudo -E handed root the entire environment:
KUBECONFIG, HOME and PATH. Root therefore ran gke-gcloud-auth-plugin and
gcloud, which is what put root-owned files under the user's ~/.kube and
~/.config/gcloud, and made every token refresh a root-run gcloud.
Now the script generates a kubeconfig minified to the context and rewrites its
exec credential to drop back to the invoking user (sudo -u USER -H), so the
forwarder is the only thing running as root and all it ever receives is a
bearer token. Contexts without an exec block (client certs, local clusters)
pass through untouched. Preflight runs as the user so an expired login is
reported in your own session instead of from inside the root process.
The env hop in those exec args is load-bearing: sudo resets PATH to
secure_path, where the plugin fails with
exec: "gcloud": executable file not found in $PATH
so PATH is restored to the plugin's own directory, where gcloud is a sibling.
1.25.12 -> 1.25.16 also brings idle mode: with no -n/-A kubefwd now starts its
REST API and waits instead of forwarding, which the script now says out loud
rather than looking hung. Running the script itself as root is refused, and
the already-running guard exits 10 with pgrep -l (BSD pgrep has no -a).
Verified with a stub sudo: argument assembly, the generated credential, that
the rewritten exec command really returns an ExecCredential, and that 1.25.16
accepts our flags ahead of the svc subcommand.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The previous commit kept the exec plugin in the kubeconfig and only moved it
back to the invoking user with sudo -u. Root still drove it, and kubefwd
re-invokes the credential every minute or two (552 config-helper calls on
2026-08-11, 1071 on 08-12), so every one of those became a sudo as well. It
also left a gcloud-shaped hop in a script that has no business knowing about
gcloud.
Resolve the credential here instead, once, as the invoking user, and give
kubefwd a kubeconfig holding only the token that came back. This is the
client-go exec protocol, so nothing about it is gcloud specific: args, env and
KUBERNETES_EXEC_INFO all come from the context's own exec block, whatever
plugin it names. Contexts without one, client certificates on local clusters or
a static token, pass through untouched, and that is also where the long
sessions happen.
The trade is now stated instead of implicit: a GKE token lasts an hour and is
not renewed for a running kubefwd, so its expiry is printed at startup.
Two details worth keeping:
- The exec block has to be dropped, not just overwritten with a token. kubectl
keeps both and exec wins. Done with a fresh user entry plus a re-minify,
because unsetting users.NAME.exec needs a dotted path that breaks on user
names containing dots.
- Plugin stderr is captured separately. Folding it into stdout corrupts the
ExecCredential of any plugin that warns while succeeding, which a stub
reproduced.
Verified with stub plugins: the token path, a failing plugin, a plugin
answering with client certificates, that KUBERNETES_EXEC_INFO arrives
well-formed, and that a client-certificate context reaches kubefwd unchanged.
No cluster was contacted.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@solsson
solsson merged commit 4e5fd75 into mainAug 31, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@solsson