Uh oh!
There was an error while loading. Please reload this page.
Harden Curier for v0.1.0 - #1
Merged
Merged
Conversation
zekageri
marked this pull request as ready for review
July 31, 2026 06:58
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden Curier's lifecycle, endpoint handling, cryptographic qualification, and release CI before the v0.1.0 tag.
What changed
end()so successful shutdown returns only after normal or capability-created task allocations are reclaimedend()timeout so a later call can finish cleanupend()behavior, retries, retry cancellation, shutdown timeout recovery, and repeated lifecycle heap recoveryRoot cause
The worker previously signaled completion and then deleted itself. This allowed
end()to release runtime state and report success before task deletion had completed. Destroying Curier from its callback avoided use-after-free by releasing the implementation pointer, but permanently leaked the runtime. Endpoint parsing also allowed malformed authorities that could be interpreted differently by VAPID audience construction and the HTTP client.Validation
GitHub Actions passes:
Before marking ready
Run
LifecycleSmokeandRuntimeSemanticson a real PSRAM-capable production target and confirm stable internal/PSRAM heap and successful runtime output.