Uh oh!
There was an error while loading. Please reload this page.
Harden Phase for v0.1.0 release - #2
Merged
Merged
Conversation
zekageri
marked this pull request as ready for review
July 15, 2026 09:41
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the v0.1.0 release-hardening work tracked in #1.
Runtime safety
end()returns only after the worker has stopped accessingPhaseImplend()from lifecycle callbacks and other Phase-task callbacks instead of deadlockingPhaseImpldestruction when aPhaseobject is destroyed from its own callbackDeterministic lifecycle execution
std::string, dependency-vector, andstd::functionruntime snapshotsonChange()Diagnostics and release gates
end()rejection, cancellation/restart, teardown, and zero lifecycle allocationslibrary.json,library.properties, and README status to0.1.0Root cause
The previous implementation published task completion before the FreeRTOS worker had fully stopped using its owner, copied allocating STL objects during lifecycle execution, and exposed pointers into mutable callback state. Compilation-only CI could not detect these behavioral and concurrency failures.
Validation
Locally executed with warnings as errors:
Result:
Phase host tests passed.The draft PR CI will additionally compile every example with PIOArduino and Arduino CLI for ESP32, ESP32-S3, ESP32-C3, and ESP32-P4.
Review notes
Phase.cppremains a single translation unit. Its implementation is split into internal.incfragments to make the state machine and public control paths easier to review without changing library linkage or exposing new public headers.Addresses #1.