Uh oh!
There was an error while loading. Please reload this page.
Migrate Worker memory ownership to Strata - #2
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.2.0and require Stratav0.1.1WorkerStackTypewith the sharedStrata::MemoryPolicy/Strata::Placementvocabularystd::nulloptinheritancestd::stringto staticconst char *v0.1.0Compatibility
This intentionally establishes a clean
v0.2.0API rather than carrying Worker-specific compatibility aliases:WorkerStackType::Auto->Strata::Placement::PreferExternalWorkerStackType::Internal->Strata::Placement::InternalWorkerStackType::Psram->Strata::Placement::RequireExternaldefaultStackType->memory.taskStackstackType-> optionalstackPlacementWorkerResult::messageis nowconst char *Worker remains responsible for jobs, callbacks, cooperative cancellation, sleep/wait behavior, concurrency, and cleanup orchestration. Strata now owns allocation placement and low-level task/queue/mutex storage.
Validation
Validated on PR head
28b93811524f5ff9491137931af04f28f2fb6728:The
TaskCleanupSentinelexample now compiles underPreferExternalgeneral allocation and task-stack policies. Source audits reject direct ESP-IDF heap capabilities, rawnew/delete, and direct dynamic task/queue/semaphore creation from production Worker sources.