Fix underline formatting on Hytale 0.5 - #7
Open
Jhiynn wants to merge 1 commit into
Open
Conversation
Zoltus
commented
Jun 6, 2026
Owner
Thanks for the pr. Does it stil lwork with the latest? I might merge it, |
Author
Works. But my Agent did everything automatically. So should review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.hypixel.hytale.protocol.MaybeBoolwhen applying underline formatting.FormattedMessage.underlinedat runtime so TinyMessage works with both the olderMaybeBoolprotocol shape and the newerBooleanfield used by Hytale 0.5.x.0.5.0because the previous2026.01.24-6e2d4fc36artifact is no longer available from the release Maven repository.Why
On Hytale 0.5.x,
MaybeBoolno longer exists incom.hypixel.hytale.protocol. Parsing a message with underline formatting, for example<u>text</u>, can throw:This happened while TinyMessage was used by BerryChat, and the exception was raised from
TinyMsg.createStyledMessagewhile handling a custom UI link click.Testing
./gradlew.bat clean build0.5.0:<u>hi</u>setsFormattedMessage.underlinedtoBoolean true.0.4.0:<u>hi</u>still setsFormattedMessage.underlinedtoMaybeBool.True.