Skip to content

[Fix] Chat controls fade into light IDE themes - #1298

Merged
edelauna merged 3 commits into
mainfrom
fix/theme-aware-chat-controls-157cfn81c2ad4
Aug 20, 2026
Merged

[Fix] Chat controls fade into light IDE themes#1298
edelauna merged 3 commits into
mainfrom
fix/theme-aware-chat-controls-157cfn81c2ad4

Conversation

@zoomote

@zoomotezoomoteBot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

  • Replaced translucent-white selector borders and hover fills with shared VS Code dropdown, toolbar-hover, and focus tokens across mode, API configuration, auto-approval, and generic dropdown triggers.
  • Replaced the fixed white todo-delete overlay with the existing accessible, theme-aware alert dialog.
  • Added cancel/delete interaction coverage, enabled/disabled selector branch coverage, and light/dark computed-style checks for hover and keyboard focus states.

Why this change was made

These controls were designed around dark backgrounds, causing borders and interaction feedback to fade into light IDE themes. This follow-up addresses the confirmed token bypasses identified during the Mermaid light-theme audit.

Impact

The affected selectors and todo-delete confirmation remain visible and consistent in light and dark themes without changing their behavior. Real extension screenshots remain unavailable because this environment exposes the docs site but not the VS Code extension UI.

@codecov

codecovBot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@edelauna
edelaunaforce-pushed the fix/theme-aware-chat-controls-157cfn81c2ad4 branch from 3fff57c to 0e650c4CompareAugust 20, 2026 20:53
@edelauna
edelauna marked this pull request as ready for review August 20, 2026 20:57
@edelauna
edelauna enabled auto-merge August 20, 2026 20:58
@edelauna
edelauna added this pull request to the merge queueAug 20, 2026
@edelauna
edelauna removed this pull request from the merge queue due to a manual request Aug 20, 2026
@github-actionsgithub-actionsBot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Aug 20, 2026
@edelauna
edelauna added this pull request to the merge queueAug 20, 2026
Merged via the queue into main with commit 871bb98Aug 20, 2026
26 checks passed
@edelauna
edelauna deleted the fix/theme-aware-chat-controls-157cfn81c2ad4 branch August 20, 2026 21:22
everyoneexe added a commit to everyoneexe/Zoo-Code that referenced this pull request Aug 26, 2026
Shared control heights grew after merging main's cross-theme legibility
changes (Zoo-Code-Org#1298, Zoo-Code-Org#1312, Zoo-Code-Org#1333), shifting these panels 2-36px taller. The
layout is otherwise unchanged; regenerate the dark-theme baselines so the
Playwright CT suite passes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-reviewPR changes are ready and waiting for maintainer re-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@edelauna@roomote